1285240 - trim leading and trailing space from link text when finding elements

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

In FirefoxDriver they strip the leading and trailing white space when searching for link text elements

I have updated the spec in https://github.com/w3c/webdriver/pull/312

Comment 1

[David Burns :automatedtester]

Attachment: Bug 1285240: Trim leading and trailing space when finding elements by link text

This gives up parity with the WebDriver project and brings us in line with the current
specification http://w3c.github.io/webdriver/webdriver-spec.html#dfn-link-text

Review commit: https://reviewboard.mozilla.org/r/62948/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62948/

Comment 2

[David Burns :automatedtester]

Attachment: Bug 1285240: Update tests to prevent redefinitions

The tests had the same name which caused a redefinition meaning only one of the tests
was run.

Review commit: https://reviewboard.mozilla.org/r/62950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/62950/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8768971 [details]
Bug 1285240: Update tests to prevent redefinitions

https://reviewboard.mozilla.org/r/62950/#review59898

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8768970 [details]
Bug 1285240: Trim leading and trailing space when finding elements by link text

https://reviewboard.mozilla.org/r/62948/#review59900

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e7d0a3aab62
Trim leading and trailing space when finding elements by link text r=ato
https://hg.mozilla.org/integration/autoland/rev/0ac60b8ebc49
Update tests to prevent redefinitions r=ato

Comment 7

[David Burns :automatedtester]

Sheriffs, once this hits central please can you uplift all the way to beta

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5e7d0a3aab62
https://hg.mozilla.org/mozilla-central/rev/0ac60b8ebc49

Comment 9

[Carsten Book [:Tomcat]]

has problems to apply to aurora:

David could you take a look, thanks!

grafting 353324:5e7d0a3aab62 "Bug 1285240: Trim leading and trailing space when finding elements by link text r=ato"
remote changed testing/marionette/harness/marionette/tests/unit/test_element_retrieval.py which local deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? c
merging testing/marionette/element.js
warning: conflicts while merging testing/marionette/element.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f3111d767fd7
https://hg.mozilla.org/releases/mozilla-aurora/rev/1609e0acfe66

Comment 11

[David Burns :automatedtester]

I landed this myself