1285265 - Only enable captive portal detection on nightly

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Valentin Gosu [:valentin] (he/him)]

The captive portal UI isn't completely implemented yet.
In order to avoid this hitting release and the users having to deal with an unfinished experience, I suggest that we only turn on the pref on nightly.
Patch incoming.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Only enable captive portal detection on nightly

MozReview-Commit-ID: 6pp3J3FpYe3

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8768803 [details] [diff] [review]
Only enable captive portal detection on nightly

Review of attachment 8768803 [details] [diff] [review]:
-----------------------------------------------------------------

What specifically are you wanting to improve first? I think with the notification bar (bug 989194) we are in a shippable state.

r=me if you really think there are shipping blockers but I'm not convinced yet.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

If that's case, we can definitely try to ship that. I'll close this bug after the next release if we manage to land the notification bar.

Thanks!

Comment 4

[Valentin Gosu [:valentin] (he/him)]

It seems unlikely that bug 989194 will land in the next few days.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/eb699f0f1680
Only enable captive portal detection on nightly. r=MattN

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb699f0f1680