1285281 - Fix Qwant search asset

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

In bug 1264705, we added a Qwant icon but it doesn't align with our guidelines. Let's fix this.

Mkaply has reached out to get a better asset and possibly guidelines on their end.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: qwant_qsearch_icons.zip

Fixed assets with one of the vector files they gave us. The other 2 didn't work.

Let's update these in the product

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Update XML with new image

ML file updated with new icon.

Comment 3

[Florian Quèze [:florian]]

(In reply to Anthony Lam (:antlam) from comment #0)
> In bug 1264705, we added a Qwant icon but it doesn't align with our
> guidelines. Let's fix this.

"doesn't align with our guidelines" isn't specific enough to be fixable.

Please be more specific on your description of the problem we need to fix.

Are the guidelines you are talking about Android-specific?

Comment 4

[Florian Quèze [:florian]]

Attachment: Screenshot scalled down to 16x16px

I initially looked at the patch like if it was a generic qwant.com search plugin that was going to be used for both Desktop and Android.

The new icon scaled down to 16px isn't looking good to me, the Qwant logo is tiny and barely recognizable. See attached screenshot for a comparison of the current icon, the new proposed icon, and the qwant.com favicon rendered at 16x16px. The only improvement I see is the rounded corners on the white background, but it's not obvious why we need a white background here.

So if I had to review now, it would be r-, but the answer to my needinfo about the Android guidelines may change this to r+.

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> (In reply to Anthony Lam (:antlam) from comment #0)
> > In bug 1264705, we added a Qwant icon but it doesn't align with our
> > guidelines. Let's fix this.
> 
> "doesn't align with our guidelines" isn't specific enough to be fixable.
> 
> Please be more specific on your description of the problem we need to fix.
> 
> Are the guidelines you are talking about Android-specific?

Yes, they are specific to our Mobile Browser products. This asset update unifies the Qwant asset to match our others in the UI. 

We just didn't have the time create the asset originally but now that we have been in touch with their brand team, we've created this asset that respects by their brand guidelines and our UI patterns.

I'm currently travelling but if you refer to our Awesomscreen UI and you'll see the specific inconsistency we are trying to fix.

(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> Created attachment 8770510 [details]
> Screenshot scalled down to 16x16px
> 
> I initially looked at the patch like if it was a generic qwant.com search
> plugin that was going to be used for both Desktop and Android.

No, this is for Mobile only.

Comment 6

[Flore Allemandou [:flore]]

I suppose you need info from Florian, not me ;-)

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8770299 [details] [diff] [review]
Update XML with new image

(In reply to Anthony Lam (:antlam) from comment #5)

Fair enough.

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Bug 1285281 - Update Qwant icon to our guidelines.

Review commit: https://reviewboard.mozilla.org/r/65232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/65232/

Comment 9

[Florian Quèze [:florian]]

Comment on attachment 8772424 [details]
Bug 1285281 - Update Qwant icon to our guidelines.

https://reviewboard.mozilla.org/r/65232/#review62250

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d61ac6e3421
Update Qwant icon to our guidelines. r=florian

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d61ac6e3421

Comment 12

[Mike Kaply [:mkaply]]

Comment on attachment 8772424 [details]
Bug 1285281 - Update Qwant icon to our guidelines.

Approval Request Comment
[Feature/regressing bug #]: Bug 1264705 - Adding search engine for partner
[User impact if declined]: Inconsistent search UI (bad user experience).
[Describe test coverage new/current, TreeHerder]: Try build run, tested on nightly.
[Risks and why]: Low/None. Image change only.
[String/UUID change made/needed]: None

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8772424 [details]
Bug 1285281 - Update Qwant icon to our guidelines.

[Triage Comment]
We haven't merge, so, I guess we want that in 48 & 49.
Taking it in both branch. Should be in 48 beta 10

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4fdc04bd6100

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c822aa69374

Comment 16

[Ioana Chiorean]

Attachment: New Qwant logo

The new logo is up and confirmed in latest Bet a48 Beta 10.

Comment 17

[Ioana Chiorean]

Verified on Nightly (50.0a1 - 20160725) and Aurora (49.0a2 - 20160725)