Closed Bug 1285281 Opened 3 years ago Closed 3 years ago

Fix Qwant search asset

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 50
Tracking Status
firefox48 --- verified
firefox49 --- verified
firefox50 --- verified

People

(Reporter: antlam, Assigned: mkaply)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

In bug 1264705, we added a Qwant icon but it doesn't align with our guidelines. Let's fix this.

Mkaply has reached out to get a better asset and possibly guidelines on their end.
Fixed assets with one of the vector files they gave us. The other 2 didn't work.

Let's update these in the product
Flags: needinfo?(mozilla)
ML file updated with new icon.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(mozilla)
Attachment #8770299 - Flags: review?(florian)
(In reply to Anthony Lam (:antlam) from comment #0)
> In bug 1264705, we added a Qwant icon but it doesn't align with our
> guidelines. Let's fix this.

"doesn't align with our guidelines" isn't specific enough to be fixable.

Please be more specific on your description of the problem we need to fix.

Are the guidelines you are talking about Android-specific?
Flags: needinfo?(alam)
I initially looked at the patch like if it was a generic qwant.com search plugin that was going to be used for both Desktop and Android.

The new icon scaled down to 16px isn't looking good to me, the Qwant logo is tiny and barely recognizable. See attached screenshot for a comparison of the current icon, the new proposed icon, and the qwant.com favicon rendered at 16x16px. The only improvement I see is the rounded corners on the white background, but it's not obvious why we need a white background here.

So if I had to review now, it would be r-, but the answer to my needinfo about the Android guidelines may change this to r+.
(In reply to Florian Quèze [:florian] [:flo] from comment #3)
> (In reply to Anthony Lam (:antlam) from comment #0)
> > In bug 1264705, we added a Qwant icon but it doesn't align with our
> > guidelines. Let's fix this.
> 
> "doesn't align with our guidelines" isn't specific enough to be fixable.
> 
> Please be more specific on your description of the problem we need to fix.
> 
> Are the guidelines you are talking about Android-specific?

Yes, they are specific to our Mobile Browser products. This asset update unifies the Qwant asset to match our others in the UI. 

We just didn't have the time create the asset originally but now that we have been in touch with their brand team, we've created this asset that respects by their brand guidelines and our UI patterns.

I'm currently travelling but if you refer to our Awesomscreen UI and you'll see the specific inconsistency we are trying to fix.

(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> Created attachment 8770510 [details]
> Screenshot scalled down to 16x16px
> 
> I initially looked at the patch like if it was a generic qwant.com search
> plugin that was going to be used for both Desktop and Android.

No, this is for Mobile only.
Flags: needinfo?(alam) → needinfo?(Flore)
I suppose you need info from Florian, not me ;-)
Flags: needinfo?(Flore) → needinfo?(florian)
Comment on attachment 8770299 [details] [diff] [review]
Update XML with new image

(In reply to Anthony Lam (:antlam) from comment #5)

Fair enough.
Flags: needinfo?(florian)
Attachment #8770299 - Flags: review?(florian) → review+
Comment on attachment 8772424 [details]
Bug 1285281 - Update Qwant icon to our guidelines.

https://reviewboard.mozilla.org/r/65232/#review62250
Attachment #8772424 - Flags: review?(florian) → review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/6d61ac6e3421
Update Qwant icon to our guidelines. r=florian
https://hg.mozilla.org/mozilla-central/rev/6d61ac6e3421
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment on attachment 8772424 [details]
Bug 1285281 - Update Qwant icon to our guidelines.

Approval Request Comment
[Feature/regressing bug #]: Bug 1264705 - Adding search engine for partner
[User impact if declined]: Inconsistent search UI (bad user experience).
[Describe test coverage new/current, TreeHerder]: Try build run, tested on nightly.
[Risks and why]: Low/None. Image change only.
[String/UUID change made/needed]: None
Attachment #8772424 - Flags: approval-mozilla-release?
Attachment #8772424 - Flags: approval-mozilla-beta?
Comment on attachment 8772424 [details]
Bug 1285281 - Update Qwant icon to our guidelines.

[Triage Comment]
We haven't merge, so, I guess we want that in 48 & 49.
Taking it in both branch. Should be in 48 beta 10
Attachment #8772424 - Flags: approval-mozilla-release?
Attachment #8772424 - Flags: approval-mozilla-beta?
Attachment #8772424 - Flags: approval-mozilla-beta+
Attachment #8772424 - Flags: approval-mozilla-aurora+
Attached image New Qwant logo
The new logo is up and confirmed in latest Bet a48 Beta 10.
Status: RESOLVED → VERIFIED
Verified on Nightly (50.0a1 - 20160725) and Aurora (49.0a2 - 20160725)
You need to log in before you can comment on or make changes to this bug.