Closed Bug 1285365 Opened 4 years ago Closed 4 years ago

Remove trailing whitespace from nsCSSParser & add missing includes and namespaces relying on unification

Categories

(Core :: Layout, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jyc, Assigned: jyc)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In the process of working on Bug 1273706, I found some trailing whitespace in nsCSSParser that I removed while removing trailing whitespace from my code.

In addition, because the patches add some new files, the groupings from unification changed, causing build errors due to missing includes or namespace qualifiers.

I will attach two trivial patches that remove whitespace and fix these build errors.
Attachment #8768938 - Flags: review?(dholbert)
Attachment #8768939 - Flags: review?(dholbert)
Comment on attachment 8768938 [details]
Bug 1285365 - Part 1: Remove trailing whitespace from nsCSSParser.

https://reviewboard.mozilla.org/r/62934/#review59836

Part 1 looks good - r=me. Thanks for cleaning this up!
Attachment #8768938 - Flags: review?(dholbert) → review+
Comment on attachment 8768939 [details]
Bug 1285365 - Part 2: Add missing includes and namespace qualifiers.

https://reviewboard.mozilla.org/r/62936/#review59840

part 2 looks good too. r=me

Thanks for cleaning this up!
Attachment #8768939 - Flags: review?(dholbert) → review+
You should trigger a try build for the changes here (either via mozreview or via ./mach try), just to be sure that "part 2" doesn't accidentally cause some bustage (as include/namespacing changes occasionally can).  And then I'll be happy to autoland this for you.

For the Try run, we probably just need to verify that this builds correctly, on windows/mac/linux. No need to do any unit test runs.
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb183e7c648b
Part 1: Remove trailing whitespace from nsCSSParser. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/dc8af4e3e454
Part 2: Add missing includes and namespace qualifiers. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/cb183e7c648b
https://hg.mozilla.org/mozilla-central/rev/dc8af4e3e454
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.