Closed Bug 1285428 Opened 5 years ago Closed 5 years ago

Some tables in urlclassifier.trackingWhitelistTable may be missed during table registration

Categories

(Toolkit :: Safe Browsing, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: francois, Assigned: francois)

References

Details

Attachments

(1 file)

While reviewing Dimi's first patch, I found a bug in the way it registers
the tracking protection tables: https://bugzilla.mozilla.org/show_bug.cgi?id=1281083#c8

The bug is not currently triggered because both urlclassifier.trackingTable and urlclassifier.trackingWhitelistTable have two entries, but bug 1258041 will change that and this is very likely to break table registration by returning early.

At best, it means that the plugin block list tables will never be updated and at worst that all updates will be broken.
It turns out that out of bound indices just return null and there is a null check in the listmanager:

https://dxr.mozilla.org/mozilla-central/rev/94cce4e79310565ff5b169f890842499ea713f8a/toolkit/components/url-classifier/content/listmanager.js#148

and so this bug is not as bad as I initially thought.
Severity: critical → normal
Priority: P1 → P2
Summary: urlclassifier.trackingWhitelistTable breaks Safe Browsing table registration → Some tables in urlclassifier.trackingWhitelistTable may be missed during table registration
Comment on attachment 8769044 [details]
Bug 1285428 - Fix urlclassifier.trackingWhitelistTable table registration.

https://reviewboard.mozilla.org/r/63018/#review59954
Attachment #8769044 - Flags: review?(gpascutto) → review+
Pushed by fmarier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4287a45df22d
Fix urlclassifier.trackingWhitelistTable table registration. r=gcp
https://hg.mozilla.org/mozilla-central/rev/4287a45df22d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.