1285428 - Some tables in urlclassifier.trackingWhitelistTable may be missed during table registration

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[François Marier [:francois]]

While reviewing Dimi's first patch, I found a bug in the way it registers
the tracking protection tables: https://bugzilla.mozilla.org/show_bug.cgi?id=1281083#c8

The bug is not currently triggered because both urlclassifier.trackingTable and urlclassifier.trackingWhitelistTable have two entries, but bug 1258041 will change that and this is very likely to break table registration by returning early.

At best, it means that the plugin block list tables will never be updated and at worst that all updates will be broken.

Comment 1

[François Marier [:francois]]

It turns out that out of bound indices just return null and there is a null check in the listmanager:

https://dxr.mozilla.org/mozilla-central/rev/94cce4e79310565ff5b169f890842499ea713f8a/toolkit/components/url-classifier/content/listmanager.js#148

and so this bug is not as bad as I initially thought.

Comment 2

[François Marier [:francois]]

Attachment: Bug 1285428 - Fix urlclassifier.trackingWhitelistTable table registration.

Review commit: https://reviewboard.mozilla.org/r/63018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63018/

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8769044 [details]
Bug 1285428 - Fix urlclassifier.trackingWhitelistTable table registration.

https://reviewboard.mozilla.org/r/63018/#review59954

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4287a45df22d
Fix urlclassifier.trackingWhitelistTable table registration. r=gcp

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4287a45df22d