Closed
Bug 1285438
Opened 8 years ago
Closed 8 years ago
Baldr: remove magic empty string export logic
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: luke, Assigned: luke)
References
Details
Attachments
(2 files, 1 obsolete file)
|
8.49 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
|
2.85 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
It's not in JS.md and it doesn't make sense when the export object becomes a Module Namespace Exotic Object.
Attachment #8769028 -
Flags: review?(bbouvier)
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8769215 -
Flags: review?(bbouvier)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Switch the rest of spec.js over to 'new-format' as well.
Attachment #8769215 -
Attachment is obsolete: true
Attachment #8769215 -
Flags: review?(bbouvier)
Attachment #8769220 -
Flags: review?(bbouvier)
|
||
Updated•8 years ago
|
Attachment #8769028 -
Flags: review?(bbouvier) → review+
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8769220 [details] [diff] [review]
export-needs-validation-check
Review of attachment 8769220 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8769220 -
Flags: review?(bbouvier) → review+
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad95613e3763
Baldr: remove magic empty string export logic (r=bbouvier)
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f1fd21039e8
Baldr: require memory is imported/defined if exported (r=bbouvier)
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ad95613e3763
https://hg.mozilla.org/mozilla-central/rev/8f1fd21039e8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•