1285503 - Fix DragonFly target spelling

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

Common spelling mistakes are either in capitalization or adding BSD suffix.

$ uname -sr
DragonFly 4.5-DEVELOPMENT

Comment 1

[Jan Beich]

Attachment: Bug 1285503 - Fix DragonFly target spelling after bug 1266368.

Review commit: https://reviewboard.mozilla.org/r/63074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63074/

Comment 2

[Jan Beich]

Comment on attachment 8769104 [details]
Bug 1285503 - Fix DragonFly target spelling after bug 1266368.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63074/diff/1-2/

Comment 3

[Jan Beich]

https://reviewboard.mozilla.org/r/63074/#review63290

Let's try another build peer. Ted is taking too long to review a trivial change.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8769104 [details]
Bug 1285503 - Fix DragonFly target spelling after bug 1266368.

https://reviewboard.mozilla.org/r/63074/#review63918

::: build/moz.configure/rust.configure:75
(Diff revision 2)
> +            # Bitrig
> +            ('x86_64', 'Bitrig'): 'x86_64-unknown-bitrig',

Considering Bitrig is not in python/mozbuild/mozbuild/configure/constants.py, this is not going to be any useful.

::: build/moz.configure/rust.configure:78
(Diff revision 2)
>          os_or_kernel = target.kernel if target.kernel == 'Linux' and target.os != 'Android' else target.os
>          rustc_target = {
> +            # Bitrig
> +            ('x86_64', 'Bitrig'): 'x86_64-unknown-bitrig',
>              # DragonFly
> -            ('x86_64', 'Dragonfly'): 'x86_64-unknown-dragonfly',
> +            ('x86_64', 'DragonFly'): 'x86_64-unknown-dragonfly',

Mmmmm this plus the Bitrig thing makes me thing we need to find a way to make this fail for values that aren't in constants.py.

I think this dict should move to constants.py, with an assert test like the other dicts in there.

Comment 5

[Jan Beich]

Comment on attachment 8769104 [details]
Bug 1285503 - Fix DragonFly target spelling after bug 1266368.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63074/diff/2-3/

Comment 6

[Jan Beich]

https://reviewboard.mozilla.org/r/63074/#review63918

> Considering Bitrig is not in python/mozbuild/mozbuild/configure/constants.py, this is not going to be any useful.

Dropped Bitrig for now. It needs more consistent support.

> Mmmmm this plus the Bitrig thing makes me thing we need to find a way to make this fail for values that aren't in constants.py.
> 
> I think this dict should move to constants.py, with an assert test like the other dicts in there.

Moving dict is outside of scope. It requires more care and is harder to backport to the branch where the regression occured. A poor excuse to not learn mozbuild but still...

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8769104 [details]
Bug 1285503 - Fix DragonFly target spelling after bug 1266368.

https://reviewboard.mozilla.org/r/63074/#review65578

Comment 8

[Jan Beich]

Comment on attachment 8769104 [details]
Bug 1285503 - Fix DragonFly target spelling after bug 1266368.

NPOTB for native builds (i.e. no cross-compilation) since bug 1248391

Approval Request Comment
[Feature/regressing bug #]: bug 1266368 regression
[User impact if declined]: Broken cross-build targeting DragonFly with --enable-rust
[Describe test coverage new/current, TreeHerder]: Try build via mozreview, soon on inbound
[Risks and why]: Low, can only break (cross-)build due to typos or mismerge
[String/UUID change made/needed]: None

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddb8951325ee
Fix DragonFly target spelling after bug 1266368. r=glandium

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ddb8951325ee

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8769104 [details]
Bug 1285503 - Fix DragonFly target spelling after bug 1266368.

Improved rust support, Aurora50+

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a3dcf8011547