Closed Bug 1285515 Opened 3 years ago Closed 3 years ago

Telemetry wanted: How many of each container type is open for usercontext id 1-4

Categories

(Core :: DOM: Security, defect, P2)

50 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 3 obsolete files)

No description provided.
Attached patch telemetry.patch (obsolete) — Splinter Review
bsmedberg, for a privacy point of view, this should be OK because we count only the 'standard' containers. Also when we will have about:containers, the new ones will not be counted.
Attachment #8769157 - Flags: review?(benjamin)
Whiteboard: [domsecurity-active]
Priority: -- → P2
Can you explain what questions this will answer? This sounds like the kind of data collection that should start out as temporary until you have experience with it and know whether it will be valuable.
Flags: needinfo?(amarchesini)
It is also possible to do this as a single enumerated histogram, if that would make your life easier.
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Can you explain what questions this will answer? This sounds like the kind
> of data collection that should start out as temporary until you have
> experience with it and know whether it will be valuable.

Right. The idea is: we have 4 default containers (banking, shopping, personal, work) and we would like to know which ones of them the users prefer and use.

I'm ok to use 1 single enumerated histogram. Ping me on IRC, or give me more info and I update the patch.
Flags: needinfo?(amarchesini) → needinfo?(benjamin)
Comment on attachment 8769157 [details] [diff] [review]
telemetry.patch

I'll happily mark data-review on something like this (I'm on PTO, but rweiss can mark in my absence):

"CONTAINER_USED": {
  "alert_emails": ...,
  "expires_in_version": 55,
  "kind": "enumeration",
  "n_values": 5,
  "description": "Records a value each time a builtin container is opened. 1=banking 2=shopping 3=personal 4=work. Does not record usage of user-created containers."
}
Flags: needinfo?(benjamin)
Attachment #8769157 - Flags: review?(benjamin)
Attached patch telemetry.patch (obsolete) — Splinter Review
Attachment #8769157 - Attachment is obsolete: true
Attachment #8772789 - Flags: review?(rweiss)
Attached patch telemetry.patch (obsolete) — Splinter Review
Attachment #8772789 - Attachment is obsolete: true
Attachment #8772789 - Flags: review?(rweiss)
Attachment #8772796 - Flags: review?(rweiss)
Attached patch telemetry.patchSplinter Review
Attachment #8772796 - Attachment is obsolete: true
Attachment #8772796 - Flags: review?(rweiss)
Attachment #8772841 - Flags: review?(rweiss)
Comment on attachment 8772841 [details] [diff] [review]
telemetry.patch

Maybe francois can help here as well.. ? Thanks!
Attachment #8772841 - Flags: review?(francois)
Comment on attachment 8772841 [details] [diff] [review]
telemetry.patch

Review of attachment 8772841 [details] [diff] [review]:
-----------------------------------------------------------------

datareview+ but you'll need to fix the typo before landing

::: toolkit/components/contextualidentity/ContextualIdentityService.jsm
@@ +116,5 @@
>  
>      Services.telemetry.getHistogramById("TOTAL_CONTAINERS_OPENED").add(1);
> +
> +    if (identity.telemetryId) {
> +      Services.telemetry..getHistogramById("CONTAINER_USED")

typo: double dot
Attachment #8772841 - Flags: review?(rweiss)
Attachment #8772841 - Flags: review?(francois)
Attachment #8772841 - Flags: review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40a41381cbd4
Telemetry wanted: How many of each container type is open for usercontext id 1-4, r=francois
https://hg.mozilla.org/mozilla-central/rev/40a41381cbd4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.