1285515 - Telemetry wanted: How many of each container type is open for usercontext id 1-4

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: telemetry.patch

bsmedberg, for a privacy point of view, this should be OK because we count only the 'standard' containers. Also when we will have about:containers, the new ones will not be counted.

Comment 2

[Benjamin Smedberg]

Can you explain what questions this will answer? This sounds like the kind of data collection that should start out as temporary until you have experience with it and know whether it will be valuable.

Comment 3

[Benjamin Smedberg]

It is also possible to do this as a single enumerated histogram, if that would make your life easier.

Comment 4

[Andrea Marchesini [:baku]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Can you explain what questions this will answer? This sounds like the kind
> of data collection that should start out as temporary until you have
> experience with it and know whether it will be valuable.

Right. The idea is: we have 4 default containers (banking, shopping, personal, work) and we would like to know which ones of them the users prefer and use.

I'm ok to use 1 single enumerated histogram. Ping me on IRC, or give me more info and I update the patch.

Comment 5

[Benjamin Smedberg]

Comment on attachment 8769157 [details] [diff] [review]
telemetry.patch

I'll happily mark data-review on something like this (I'm on PTO, but rweiss can mark in my absence):

"CONTAINER_USED": {
  "alert_emails": ...,
  "expires_in_version": 55,
  "kind": "enumeration",
  "n_values": 5,
  "description": "Records a value each time a builtin container is opened. 1=banking 2=shopping 3=personal 4=work. Does not record usage of user-created containers."
}

Comment 6

[Andrea Marchesini [:baku]]

Attachment: telemetry.patch

Comment 7

[Andrea Marchesini [:baku]]

Attachment: telemetry.patch

Comment 8

[Andrea Marchesini [:baku]]

Attachment: telemetry.patch

Comment 9

[Andrea Marchesini [:baku]]

Comment on attachment 8772841 [details] [diff] [review]
telemetry.patch

Maybe francois can help here as well.. ? Thanks!

Comment 10

[François Marier [:francois]]

Comment on attachment 8772841 [details] [diff] [review]
telemetry.patch

Review of attachment 8772841 [details] [diff] [review]:
-----------------------------------------------------------------

datareview+ but you'll need to fix the typo before landing

::: toolkit/components/contextualidentity/ContextualIdentityService.jsm
@@ +116,5 @@
>  
>      Services.telemetry.getHistogramById("TOTAL_CONTAINERS_OPENED").add(1);
> +
> +    if (identity.telemetryId) {
> +      Services.telemetry..getHistogramById("CONTAINER_USED")

typo: double dot

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40a41381cbd4
Telemetry wanted: How many of each container type is open for usercontext id 1-4, r=francois

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40a41381cbd4