1285527 - Implement PushSubscriptionOptions.userVisibleOnly

Status: RESOLVED INVALID

(Core :: DOM: Push Subscriptions, defect, P3)

Description

[John Mellor]

I noticed that Firefox 48 does not implement the userVisibleOnly attribute of the PushSubscriptionOptions interface.
https://w3c.github.io/push-api/#pushsubscriptionoptions-interface-and-dictionary

It's fine for UAs to ignore the value of the userVisibleOnly property of the PushSubscriptionOptionsInit dictionary, but the spec as currently written implies that UAs should nevertheless reflect the value back in the PushSubscriptionOptions interface.

Comment 1

[Lina Butler (ex-Mozilla)]

Thanks! This means we'll want to store the value that the user passes in for `userVisibleOnly`, right? (Even if we don't use it for anything else).

I'm a bit wary because we treat `.subscribe({ userVisibleOnly: true })` and `.subscribe({ userVisibleOnly: false })` the same way, so it's unclear what `userVisibleOnly` would mean in Firefox. Maybe we can use it to enforce a stronger quota, though?

Comment 2

[Martin Thomson [:mt:]]

I'd rather have the spec amended to allow UAs to only include the properties that it implements.

Comment 3

[Andrew Overholt [:overholt]]

(In reply to Martin Thomson [:mt:] from comment #2)
> I'd rather have the spec amended to allow UAs to only include the properties
> that it implements.

So should we close this and use a spec issue instead?

Comment 4

[Martin Thomson [:mt:]]

https://github.com/w3c/push-api/issues/200