Closed Bug 1285563 Opened 8 years ago Closed 8 years ago

Investigate Driver/Device/Adapter mismatches

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: BenWa, Assigned: milan)

References

(Depends on 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(4 files, 1 obsolete file)

Part 2. If the enumeration gives us the second GPU, swap the infos. r=bas
3.08 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
Part 1. Put the GPU infos in arrays. r=bas
21.23 KB, patch
bas.schouten
: review+
Details | Diff | Splinter Review
Bug 1285563: Part 1. Track two GPU infos in arrays, easier for swap if the second is active.
58 bytes, text/x-review-board-request
milan
: review+
Details
Bug 1285563: Part 2. If the second GPU is the active one, swap.
58 bytes, text/x-review-board-request
milan
: review+
Details
Right now we're blacklisting based on the DISPLAY_DEVICE_PRIMARY_DEVICE which *may* not be the device that we run D3D on. We're reporting these as mismatches in crash stats. This means that we're getting our blacklist wrong and it's pretty important to get right.
To be safer we should start with re-running the blacklist once we've created a D3D device to make sure that we're not running on a bad device/driver because of a mismatch. As a follow-up we can consider relaxing the blacklist based on DISPLAY_DEVICE_PRIMARY_DEVICE, but we can discuss the specifics later.
This might be fixed by fixing bug 1257375.
Depends on: 1257375
Whiteboard: [gfx-noted]
Depends on: 1286653
Assignee: nobody → milan
Up to date patch.
Attachment #8817574 - Attachment is obsolete: true
Attachment #8817574 - Flags: review?(bas)
Attachment #8817841 - Flags: review?(bas)
Attachment #8817841 - Flags: review?(bas) → review+
Attachment #8817575 - Flags: review?(bas) → review+
Comment on attachment 8819326 [details] Bug 1285563: Part 1. Track two GPU infos in arrays, easier for swap if the second is active. https://reviewboard.mozilla.org/r/99144/#review99440 Carry r+ from bas.
Attachment #8819326 - Flags: review+
Comment on attachment 8819327 [details] Bug 1285563: Part 2. If the second GPU is the active one, swap. https://reviewboard.mozilla.org/r/99146/#review99442 Carry r+ from bas
Attachment #8819327 - Flags: review+
Attachment #8819326 - Flags: review?(bas)
Attachment #8819327 - Flags: review?(bas)
Pushed by msreckovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0b74d386259 Part 1. Track two GPU infos in arrays, easier for swap if the second is active. r=milan https://hg.mozilla.org/integration/autoland/rev/3d4f10649284 Part 2. If the second GPU is the active one, swap. r=milan
I expect VendorIDMismatch messages in graphics critical errors to go away with this change.
https://hg.mozilla.org/mozilla-central/rev/e0b74d386259 https://hg.mozilla.org/mozilla-central/rev/3d4f10649284
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
With remote desktop, as described in bug 1325743 comment 13, we now get acceleration where before we did not. Is this a good thing?
(In reply to Milan Sreckovic [:milan] from comment #13) > With remote desktop, as described in bug 1325743 comment 13, we now get > acceleration where before we did not. Is this a good thing? Modulo some scenarios (remotefx?) we think this is probably a good thing.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: