1285605 - Report the number of Zones and Compartments swept in a GC

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: stats_on_swept_zones_compartments-v0.diff

We currently tell you how many are collected, but not whether or not we freed any. The old stats look like:

Compartments Collected: 122 of 1749

The new stats add the amount removed after in parentheses:

Compartments Collected: 122 of 1749 (-42)

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8769280 [details] [diff] [review]
stats_on_swept_zones_compartments-v0.diff

Review of attachment 8769280 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I think I've meant to do this a few times, but always got distracted.

::: js/src/gc/Statistics.cpp
@@ +391,2 @@
>                  zoneStats.collectedCompartmentCount, zoneStats.compartmentCount,
> +                zoneStats.sweptCompartmentCount,

Looks a little weird here, because the heap delta gets its own header but the compartments delta doesn't. But it looks like that's because the heap delta is in terms of chunks. So never mind, it's fine. I suppose you could change it to "Heap Chunks: %d (%+d); ", but whatever.

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c686dd1366a3c3e45a64e71fec65cd587be38dac
Bug 1285605 - Report number of Zones and Compartments swept in a GC; r=sfink

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c686dd1366a3