Cleanup the repetitive code in sdp_parse_attr_fmtp from sdp_attr.c

RESOLVED FIXED in Firefox 52

Status

()

defect
P2
normal
Rank:
29
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mjf, Assigned: mjf)

Tracking

unspecified
mozilla52
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
There is a lot of repeated code in this function that can be moved into a helper function.
Assignee

Updated

3 years ago
Rank: 29
Priority: -- → P2
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

3 years ago
mozreview-review
Comment on attachment 8804826 [details]
Bug 1285646 - Clean up the repetitive code in sdp_parse_attr_fmtp.

https://reviewboard.mozilla.org/r/88682/#review87970
Attachment #8804826 - Flags: review?(drno) → review+
Michael, please do not land. I'll update shortly...
Flags: needinfo?(mfroman)
(In reply to Nils Ohlmeier [:drno] from comment #4)
> Michael, please do not land. I'll update shortly...

Never mind. An entirely different problem. Land at your earliest convenience.
Flags: needinfo?(mfroman)
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bd422e06289a
Clean up the repetitive code in sdp_parse_attr_fmtp. r=drno
Keywords: checkin-needed

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bd422e06289a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.