1285662 - NUWA looks broken

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

Consequence of bug 1285157

Comment 1

[:gerard-majax]

Attachment: debug-nuwa.patch

Comment 2

[:gerard-majax]

Attachment: broken nuwa log

Comment 3

[:gerard-majax]

Attachment: ok nuwa log

Comment 4

[:gerard-majax]

It would looks like we are getting called into ContentChild::Init() later when it is broken, according to the "HELLO NUWA"

Comment 5

[:gerard-majax]

Well the change really introducing the problem seems to be bug 1283744

Comment 6

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> It would looks like we are getting called into ContentChild::Init() later
> when it is broken, according to the "HELLO NUWA"

As much as I can tell, we get blocked when doing GetFileDescriptor() at https://dxr.mozilla.org/mozilla-central/source/ipc/chromium/src/chrome/common/ipc_channel_posix.cc#929 from GetProtoFdInfos(), at |content->GetTransport()->GetFileDescriptor()|: https://dxr.mozilla.org/mozilla-central/source/dom/ipc/NuwaChild.cpp?q=content-%3EGetTransport%28%29-%3EGetFileDescriptor%28%29%3B&redirect_type=single#165

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Workaround: disable_nuwa.patch

Comment 8

[:gerard-majax]

Let's just remove NUWA completely.

Comment 9

[Gabriele Svelto [:gsvelto]]

Note that we're still interested in doing something along the lines in desktop Firefox (see bug 876173). Doing it across four different OSes is going to be much tougher than NUWA though.

Comment 10

[Gregor Wagner [:gwagner]]

(In reply to Gabriele Svelto [:gsvelto] from comment #9)
> Note that we're still interested in doing something along the lines in
> desktop Firefox (see bug 876173). Doing it across four different OSes is
> going to be much tougher than NUWA though.

We can add the code again if we need to. Right now its just a feature thats neither tested nor used.

Comment 11

[:gerard-majax]

Attachment: Bug 1285662 - Remove NUWA r?

Review commit: https://reviewboard.mozilla.org/r/68554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/68554/

Comment 12

[:gerard-majax]

Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/1-2/

Comment 13

[:gerard-majax]

Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/2-3/

Comment 14

[:gerard-majax]

Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/3-4/

Comment 15

[[:fabrice] Fabrice Desré]

I guess this patch should actually be in bug 1284674, and this one should be closed.

Comment 16

[:gerard-majax]

Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/4-5/