Closed Bug 1285662 Opened 3 years ago Closed 3 years ago

NUWA looks broken

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

Attachments

(4 files, 1 obsolete file)

Consequence of bug 1285157
Attached patch debug-nuwa.patchSplinter Review
Attached file broken nuwa log
Attached file ok nuwa log
It would looks like we are getting called into ContentChild::Init() later when it is broken, according to the "HELLO NUWA"
Well the change really introducing the problem seems to be bug 1283744
Depends on: 1283744
(In reply to Alexandre LISSY :gerard-majax from comment #4)
> It would looks like we are getting called into ContentChild::Init() later
> when it is broken, according to the "HELLO NUWA"

As much as I can tell, we get blocked when doing GetFileDescriptor() at https://dxr.mozilla.org/mozilla-central/source/ipc/chromium/src/chrome/common/ipc_channel_posix.cc#929 from GetProtoFdInfos(), at |content->GetTransport()->GetFileDescriptor()|: https://dxr.mozilla.org/mozilla-central/source/dom/ipc/NuwaChild.cpp?q=content-%3EGetTransport%28%29-%3EGetFileDescriptor%28%29%3B&redirect_type=single#165
Let's just remove NUWA completely.
Note that we're still interested in doing something along the lines in desktop Firefox (see bug 876173). Doing it across four different OSes is going to be much tougher than NUWA though.
(In reply to Gabriele Svelto [:gsvelto] from comment #9)
> Note that we're still interested in doing something along the lines in
> desktop Firefox (see bug 876173). Doing it across four different OSes is
> going to be much tougher than NUWA though.

We can add the code again if we need to. Right now its just a feature thats neither tested nor used.
Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/1-2/
Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/2-3/
Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/3-4/
I guess this patch should actually be in bug 1284674, and this one should be closed.
Comment on attachment 8776920 [details]
Bug 1285662 - Remove NUWA r?

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/68554/diff/4-5/
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
Attachment #8776920 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.