1285664 - Add a text-to-speech mode to Reader View

Status: NEW

(Firefox for iOS :: Reader View, defect, P3)

Description

[Nathanael Alcock]

Having Firefox read out your articles for you on mobile would be an ideal fit for Reader View.

Comment 1

[Nathanael Alcock]

I have a working demo for this feature, but it's lacking any interface at the moment.
https://github.com/varkor/firefox-ios/tree/ReaderViewTextToSpeech
In this branch, I've overridden the functionality of the style ("Aa") button in the Reader View toolbar so that tapping it once starts/pauses the dictation.
:tecgirl, would you be able to look over the feature and see what you think regarding a way to trigger this function? An obvious solution would just be to add another button to the toolbar, but that could make things a little crowded. Thanks!

Comment 2

[Nathanael Alcock]

Attachment: Pull request

Comment 3

[Nathanael Alcock]

Attachment: Simulator Screen Shot 24 авг. 2016 г., 13.09.11.png

Comment 4

[Nathanael Alcock]

Attachment: Simulator Screen Shot 24 авг. 2016 г., 13.09.28.png

Comment 5

[Robin Andersen [:tecgirl]]

let me noodle on this a bit as far as the UI is concerned. Adding the functionality to the toolbar isn't so bad, but I'm thinking it should be an audio icon (speaker or similar) and I'm wondering about how to best display the toolbar – it is crowded and confusing. I've been meaning to revisit it anyway. :) 

does this read in whatever the region language is set to?

Comment 6

[Nathanael Alcock]

I was thinking the same thing regarding the icon — it's not quite so clear at the moment. Also, I wasn't sure whether it would be desirable to have more controls (e.g. rewind), but I couldn't comfortably fit them in the toolbar, so I left them out for now.

It does read in the correct language as long as the web page has the right locale metadata, and will fall back to the user's language preference if not.

Comment 7

[Aaron Train [:aaronmt]]

Resetting assignee. Note that there are pending reviews here.

Comment 8

[Brian Nicholson (:bnicholson)]

Robin, did we ever figure out a UI for this?

Comment 9

[Brian Nicholson (:bnicholson)]

Comment on attachment 8784059 [details] [review]
Pull request

Removing myself from review for now since this still has pending UI.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit BugBot documentation.