1285750 - Remove __defineGetter__ telemetry

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S]

Attachment: Remove __define{G,S}etter_ telemtry

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 8769437 [details] [diff] [review]
Remove __define{G,S}etter_ telemtry

Review of attachment 8769437 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/SelfHostingDefines.h
@@ -94,1 @@
>  

Looks like there's an extra blank line to remove here.

::: js/src/jsfriendapi.h
@@ +132,5 @@
>      JS_TELEMETRY_GC_MINOR_REASON_LONG,
>      JS_TELEMETRY_GC_MINOR_US,
>      JS_TELEMETRY_DEPRECATED_LANGUAGE_EXTENSIONS_IN_CONTENT,
>      JS_TELEMETRY_DEPRECATED_LANGUAGE_EXTENSIONS_IN_ADDONS,
> +    JS_TELEMETRY_ADDON_EXCEPTIONS

I think you can/should keep the trailing comma on this, these days.

::: js/src/vm/SelfHosting.cpp
@@ -1893,5 @@
>      return true;
>  }
>  
>  static bool
> -intrinsic_AddContentTelemetry(JSContext* cx, unsigned argc, Value* vp)

I'd be somewhat surprised if we don't need this in the future at some point.  I'd be somewhat inclined to keep it around, to be honest.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d60c87d89619
Remove __defineGetter__/__defineSetter__ telemetry. r=Waldo

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d60c87d89619