Closed
Bug 1285751
Opened 8 years ago
Closed 8 years ago
Use brandShortName in a notification shown after Sync is connected.
Categories
(Firefox :: Sync, defect, P5)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
2.85 KB,
patch
|
markh
:
review+
|
Details | Diff | Splinter Review |
Related to bug 1285680. Currently "Firefox" string is used in a notification shown after Sync is connected. It should use brandShortName instead.
|
Assignee | |
Comment 1•8 years ago
|
||
Changed syncStartNotification.body name to syncStartNotification.body2, and "Firefox" to "%S" there, to replace it with brandShortName.
Assignee: nobody → arai.unmht
Attachment #8769438 -
Flags: review?(markh)
|
||
Comment 2•8 years ago
|
||
Ryan, what's the verdict here. I know we unconditionally use "Firefox" in "Firefox Sync" and "Firefox Account", but this string is "Firefox will begin syncing momentarily." so using "Nightly" etc might make sense there?
Flags: needinfo?(rfeeley)
|
||
Comment 3•8 years ago
|
||
"%S will begin syncing momentarily." is okay in this context. I think there are others where it is less okay. We don't want people think think that they are only syncing with other brandShortName.
Flags: needinfo?(rfeeley)
|
|
||
Comment 4•8 years ago
|
||
Sorry Ryan, but I'm not quite clear on what you are saying - should Nightly say "Nightly will begin syncing momentarily" or "Firefox will begin syncing momentarily"
Flags: needinfo?(rfeeley)
Priority: -- → P5
|
|
||
Comment 5•8 years ago
|
||
"Nightly will begin syncing momentarily" (I was referring to other completely different strings where putting in the brandShortName is not appropriate)
Flags: needinfo?(rfeeley)
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8769438 [details] [diff] [review] Use brandShortName in a notification shown after Sync is connected. Review of attachment 8769438 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8769438 -
Flags: review?(markh) → review+
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fcb08d928079 Use brandShortName in a notification shown after Sync is connected. r=markh
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fcb08d928079
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
You need to log in
before you can comment on or make changes to this bug.
Description
•