Closed Bug 1285755 Opened 4 years ago Closed 4 years ago

Have a function to convert a task graph JSON to a TaskGraph object

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: martianwars, Assigned: martianwars, Mentored)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → kalpeshk2011
Blocks: 1281062
Comment on attachment 8769439 [details]
Bug 1285755 - Adding a from_json function to TaskGraph and each Task subclass.

https://reviewboard.mozilla.org/r/63346/#review60326

I like this!  However, you'll have a conflict with the action-tasks patch that just got r+ -- ideally this patch would be modified to use kind_implementation before landing.
Attachment #8769439 - Flags: review?(dustin)
Comment on attachment 8769439 [details]
Bug 1285755 - Adding a from_json function to TaskGraph and each Task subclass.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63346/diff/1-2/
Attachment #8769439 - Flags: review?(dustin)
Attachment #8769439 - Flags: review?(dustin) → review+
Comment on attachment 8769439 [details]
Bug 1285755 - Adding a from_json function to TaskGraph and each Task subclass.

https://reviewboard.mozilla.org/r/63346/#review60364

Awesome!  And I agree -- land this first.
Keywords: checkin-needed
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b1a86b2b81ff
Adding a from_json function to TaskGraph and each Task subclass. r=dustin
Keywords: checkin-needed
Wes, did this get backed out?  I can't find it on inbound or central.  Should I be rebasing onto autoland now?
Flags: needinfo?(wkocher)
https://hg.mozilla.org/mozilla-central/rev/b1a86b2b81ff
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.