1285755 - Have a function to convert a task graph JSON to a TaskGraph object

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Kalpesh Krishna [:martianwars]]

This is with reference to https://bugzilla.mozilla.org/show_bug.cgi?id=1281062#c17

Comment 2

[Kalpesh Krishna [:martianwars]]

Attachment: Bug 1285755 - Adding a from_json function to TaskGraph and each Task subclass.

Review commit: https://reviewboard.mozilla.org/r/63346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63346/

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8769439 [details]
Bug 1285755 - Adding a from_json function to TaskGraph and each Task subclass.

https://reviewboard.mozilla.org/r/63346/#review60326

I like this!  However, you'll have a conflict with the action-tasks patch that just got r+ -- ideally this patch would be modified to use kind_implementation before landing.

Comment 4

[Kalpesh Krishna [:martianwars]]

Comment on attachment 8769439 [details]
Bug 1285755 - Adding a from_json function to TaskGraph and each Task subclass.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63346/diff/1-2/

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8769439 [details]
Bug 1285755 - Adding a from_json function to TaskGraph and each Task subclass.

https://reviewboard.mozilla.org/r/63346/#review60364

Awesome!  And I agree -- land this first.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1a86b2b81ff
Adding a from_json function to TaskGraph and each Task subclass. r=dustin

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Wes, did this get backed out?  I can't find it on inbound or central.  Should I be rebasing onto autoland now?

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b1a86b2b81ff

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

^