Closed Bug 1285894 Opened 8 years ago Closed 8 years ago

[e10s-multi] With multiple content processes: TEST-UNEXPECTED-FAIL | dom/security/test/mixedcontentblocker/test_bug803225.html | Test timed out.

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: gkrizsanits, Assigned: gkrizsanits)

References

Details

(Whiteboard: [e10s-multi:M1])

Attachments

(1 file)

This test times out because "content-document-global-created" observer never gets notified for the mailto test. There is a webHandler involved in the test it can be related.

http://searchfox.org/mozilla-central/source/dom/security/test/mixedcontentblocker/test_bug803225.html
http://searchfox.org/mozilla-central/source/dom/security/test/mixedcontentblocker/file_main_bug803225.html

 08:33:57     INFO -  418 INFO TEST-PASS | dom/security/test/mixedcontentblocker/test_bug803225.html | resource with unsafe about protocol loaded
 08:33:57     INFO -  419 INFO TEST-PASS | dom/security/test/mixedcontentblocker/test_bug803225.html | resource with data protocol did not load
 08:33:57     INFO -  420 INFO TEST-PASS | dom/security/test/mixedcontentblocker/test_bug803225.html | resource with about protocol did not load
 08:33:57     INFO -  421 INFO TEST-PASS | dom/security/test/mixedcontentblocker/test_bug803225.html | resource with javascript protocol did not load
 08:33:57     INFO -  422 INFO TEST-PASS | dom/security/test/mixedcontentblocker/test_bug803225.html | resource with resource protocol did not load
 08:33:57     INFO -  423 INFO TEST-PASS | dom/security/test/mixedcontentblocker/test_bug803225.html | resource with mozicon protocol did not load
 08:33:57     INFO -  424 INFO TEST-PASS | dom/security/test/mixedcontentblocker/test_bug803225.html | resource with wss protocol did not load
08:33:57 INFO - 425 INFO TEST-UNEXPECTED-FAIL | dom/security/test/mixedcontentblocker/test_bug803225.html | Test timed out.
Blocks: e10s-multi
Whiteboard: [e10s-multi:M?]
Blocks: e10s-tests
tracking-e10s: --- → +
Tracy, I use e10s-multi for a followup project after e10s. These are separated bugs, please don't track them for e10s.
Flags: needinfo?(twalker)
No longer blocks: e10s-tests
tracking-e10s: + → ---
got it, sorry about that. Let's get these filtered out of the e10s triage list.
Flags: needinfo?(twalker)
Whiteboard: [e10s-multi:M?] → [e10s-multi:M1]
So it looks like that the fix for bug 1242775, does ask the parent to open a new window and load something with a mailto protocol there, and then in the child it registers an observer for "content-document-global-created". The problem is that with multiple content processes the new window the parent opens will end up in another process than the child where we register the observer.

The big question is if we should just fix the test, or do we want to broadcast "content-document-global-created" notifications for all content processes.
Flags: needinfo?(mrbkap)
A typical scenario that can break is if an add-on loads a jsm in the content process that registers an observer and expect that to work for all content. With simple e10s that should work but with e10s-multi that will break. Anyway, I think we should think about this problem a bit, so I wanted to give you a heads-up about it.
(In reply to Gabor Krizsanits [:krizsa :gabor] from comment #3)
> The big question is if we should just fix the test, or do we want to
> broadcast "content-document-global-created" notifications for all content
> processes.

We should figure out a way to fix the test. It doesn't make sense to propagate content-document-global-created notifications to other processes.

I can see two ways of fixing this test: we can force the opened window to use the same process as the opening document somehow, though it's difficult since a bunch of the interfaces assume that things work a certain way (and I made nsIRemoteWindowContext builtinclass) or, probably easier, would be to make file_bug803225_test_mailto.html send a message back up to the parent via SpecialPowers in order to notify the chrome script so that it can, in turn, notify the original test page that the page loaded.
Flags: needinfo?(mrbkap)
Assignee: nobody → gkrizsanits
Attachment #8775465 - Flags: review?(mrbkap)
Comment on attachment 8775465 [details] [diff] [review]
fixing test for e10s-multi. v1

Review of attachment 8775465 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: dom/security/test/mixedcontentblocker/file_main_bug803225.html
@@ +125,5 @@
> +      var os = Components.classes["@mozilla.org/observer-service;1"]
> +        .getService(Components.interfaces.nsIObserverService);
> +      var observer = {
> +        observe: function(subject, topic, data) {
> +          if(topic == "content-document-global-created" && data =="http://example.com") {

Nits:

if<space>( and space after the second ==.
Attachment #8775465 - Flags: review?(mrbkap) → review+
Pushed by gkrizsanits@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d29fb2085b93
Fixing test_bug803225.html for e10s-multi. r=mrbkap
https://hg.mozilla.org/mozilla-central/rev/d29fb2085b93
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: