Closed Bug 1285897 Opened 4 years ago Closed 4 years ago

[webvtt] make cuechange event asynchronous.

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: bechen, Assigned: bechen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

At TimeMarchesOn step 16, we dispatch a synchronous cuechange event to TextTrack. It should be asynchronous.
Comment on attachment 8770075 [details]
Bug 1285897 - Async dispatch cuechange event on TextTrack object.

https://reviewboard.mozilla.org/r/63658/#review60684
Attachment #8770075 - Flags: review?(giles) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c7dda18ec02
Async dispatch cuechange event on TextTrack object. r=rillian
Keywords: checkin-needed
backed this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e9e32ccc8cfbcc802f41f67c80938a50b7ce1a65 since with landing of this changes we had reports like https://treeherder.mozilla.org/logviewer.html#?job_id=32307869&repo=mozilla-inbound not sure if this is this change of the other
Flags: needinfo?(bechen)
Obviously bug 1285100 had been fixed.
Flags: needinfo?(bechen)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7cab1878fc
Async dispatch cuechange event on TextTrack object. r=rillian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7a7cab1878fc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.