Closed Bug 1285903 Opened 9 years ago Closed 9 years ago

[e10s-multi] Do something about dom/base/test/browser_use_counters.js

Categories

(Core :: DOM: Content Processes, defect)

Product:
Core
Component:
DOM: Content Processes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: gkrizsanits, Assigned: mrbkap)

References

Details

(Whiteboard: [e10s-multi:M1])

Attachments

(1 file, 1 obsolete file)

For checkin
1.47 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review
This seems like a bad test. It has a dozen different known intermittent bug already and it seems like we turn it to perma-orange. That might actually help to fix it. I would just remove the test and file a bug to rewrite it. 245 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 246 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for SVGSVGELEMENT_GETELEMENTBYID after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 248 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_CURRENTSCALE_getter after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 249 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 250 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for SVGSVGELEMENT_CURRENTSCALE_getter after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 252 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for SVGSVGELEMENT_CURRENTSCALE_setter after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 253 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 254 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for SVGSVGELEMENT_CURRENTSCALE_setter after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 258 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 259 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 260 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 261 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 265 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 266 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 267 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 268 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 272 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 273 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 275 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILLOPACITY after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 276 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILLOPACITY after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 277 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 278 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 282 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 283 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 284 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 288 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 289 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 290 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 294 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 295 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 299 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | page counts for PROPERTY_FILL after are correct - Got 0, expected 1 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9 Show / Hide more 300 INFO TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | top level document counts are correct - 1224873 Intermittent e10s browser_use_counters.js | document counts for PROPERTY_FILL after are correct - Got 10, expected 9
Blocks: e10s-multi
Whiteboard: [e10s-multi:M?]
Blocks: e10s-tests
tracking-e10s: --- → +
No longer blocks: e10s-tests
tracking-e10s: + → ---
Flags: needinfo?(mrbkap)
I spent some time looking into this and the most obvious problem (to start with) is that we set nsITelemetry.canRecordExtended to true in a single process before the test goes on to load a bunch more processes. Furthermore, I haven't tested, but I wonder, given code like: let newTab = gBrowser.addTab( "about:blank"); gBrowser.selectedTab = newTab; newTab.linkedBrowser.stop(); // Do stuff in a ContentTask spawned in newTab.linkedBrowser newTab.linkedBrowser.loadURI("http://..."); can we assume that the load gets the same process? We might need a way for the frontend to ask for a given browser load to use a particular process (or pass in another browser to be considered as the "opener" for the new load). That would probably fall under the work in bug 1267653 with a little fix in this test to ensure that we use the right process for everything. Or, much easier would be to just turn off multiprocess for this test.
Flags: needinfo?(mrbkap)
Attached patch Easy fix (obsolete) — — Splinter Review
This works. I wonder if we should clone this test to have a version testing multiple content processes, though.
Attachment #8772650 - Flags: review?(gkrizsanits)
Nathan, do you have an opinion on how to proceed with this test/testing for this stuff in e10s-multi? Do we need another test to make sure this works in the new world we're moving into?
Assignee: nobody → mrbkap
Flags: needinfo?(nfroyd)
Whiteboard: [e10s-multi:M?] → [e10s-multi:M1]
Comment on attachment 8772650 [details] [diff] [review] Easy fix Review of attachment 8772650 [details] [diff] [review]: ----------------------------------------------------------------- I would avoid cloning it while it has known intermittent failures.
Attachment #8772650 - Flags: review?(gkrizsanits) → review+
(In reply to Blake Kaplan (:mrbkap) from comment #3) > Nathan, do you have an opinion on how to proceed with this test/testing for > this stuff in e10s-multi? Do we need another test to make sure this works in > the new world we're moving into? I think turning off multiprocess here is the right thing to do. Extra tests might be needed, but perhaps those will come about as part of things like bug 1218576?
Flags: needinfo?(nfroyd)
Attachment #8772650 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/69ed8adfc7b8 Force one content process for browser_use_counters.js because the test doesn't work if different tabs load in different processes. r=gabor
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/69ed8adfc7b8
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: