Closed
Bug 1285925
Opened 8 years ago
Closed 8 years ago
Remove unnecessary usages of the mock_post_json fixture
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
After the various deps of bug 1211414, the tests only post to Treeherder's own API in a few cases (ie only when explicitly testing the API), so the fixture is not required for the other tests that now interact only with the DB.
|
||
Comment 1•8 years ago
|
||
|
Assignee | |
Updated•8 years ago
|
Attachment #8769644 -
Flags: review?(james)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8769644 [details] [review] [treeherder] mozilla:mock_post_json-cleanup > mozilla:master Just noticed that James is away again this week (via the meeting notes page; don't think there was anything via email/the Bugzilla display name sadly wasn't changed :-/), so would you mind taking a look at this and the other one? :-)
Attachment #8769644 -
Flags: review?(james) → review?(wlachance)
|
||
Updated•8 years ago
|
Attachment #8769644 -
Flags: review?(wlachance) → review+
|
||
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/aec1a3a267cbaa8e092c9f6b49fa2b3a529be3d6 Bug 1285925 - Remove unnecessary usages of the mock_post_json fixture All tests other than those testing the API no longer hit the API (as of bug 1211414), so don't need to use the `mock_post_json` fixture.
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•