1285986 - crypto.subtle.encrypt throws wrong error for bad IV length with AES-CBC

Status: RESOLVED FIXED

(Core :: DOM: Web Crypto, defect)

Description

[Charles Engelke]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Steps to reproduce:

Open the JavaScript console. Enter the following code:

    crypto.subtle.generateKey({name: "AES-CBC", length:128}, false, ["encrypt", "decrypt"])
    .then(function(key) {
        crypto.subtle.encrypt(
            {name: "AES-CBC", iv: crypto.getRandomValues(new Uint8Array(8))}, 
            key, crypto.getRandomValues(new Uint8Array(32)))
        .then(function(plaintext) {console.log(plaintext.byteLength);})
        .catch(function(err) {console.log(err.name);});
    });


Actual results:

The console displays "DataError".


Expected results:

The console should have displayed "OperationError" because the IV is not 16 bytes long. See https://w3c.github.io/webcrypto/Overview.html#aes-cbc-operations .

Comment 1

[CarByte]

Attachment: Bug 1285986 - [Web Crypto] Changed error when AES-CBC, AES-CTR has wrong iv length r=keeler

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc1d2b9d698b
[Web Crypto] Changed error when AES-CBC, AES-CTR has wrong iv length r=keeler

Comment 3

[Cristian Tuns]

Backed out for causing wpt failures on aes_cbc.https.any.worker.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /WebCryptoAPI/encrypt_decrypt/aes_cbc.https.any.worker.html | AES-CBC 128-bit key, 64-bit IV - expected FAIL

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48b456031b04
[Web Crypto] Changed error when AES-CBC, AES-CTR has wrong iv length r=keeler

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/48b456031b04