1286059 - crypto.subtle.encrypt with AES-GCM and a bad tag length throws incorrect error

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P3)

Description

[Charles Engelke]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160708004052

Steps to reproduce:

Open the JavaScript console and run the following code:

    crypto.subtle.generateKey(
        {name: "AES-GCM", length: 128}, 
        false, ["encrypt", "decrypt"]
    ).then(function(key) {
        return crypto.subtle.encrypt(
            {name: "AES-GCM", tagLength: 48, iv: new Uint8Array(16), additionalData: new Uint8Array(8)}, 
            key, new Uint8Array(32));
        }).then(function(ciphertext) {
            console.log("Okay");})
        .catch(function(err) {console.log(err.name);})


Actual results:

It displayed "SyntaxError" in the console.


Expected results:

It should have displayed "OperationError". See https://w3c.github.io/webcrypto/Overview.html#aes-gcm-operations, step 5 of the encrypt operation.

Comment 1

[Michelle Funches - QA]

Hi Charles, feel free to update the component, I was alerted to this because we want to avoid issues remaining to long in an Untriaged state.
Confirmed Reproducible
Version 	49.0a2
Build ID 	20160714004054
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Version 	50.0a1
Build ID 	20160714030208

Comment 2

[Charles Engelke]

Michelle - I'm not sure what you're asking me. I've been working on the WebCryptoAPI test suite for Test the Web Forward and reporting bugs as I find them. Do you need more details of this one?

Comment 3

[R. Martinho Fernandes [:rmf]]

Attachment: Bug 1286059 - throw correct error when encrypting with a bad AES-GCM tag length

Depends on D80010

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73f73d6d927f
throw correct error when encrypting with a bad AES-GCM tag length r=keeler

Comment 5

[Razvan Maries]

Backed out for perma failures.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1270634#c9

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52f94e93c6e5
Backed out 6 changesets (bug 1286059, bug 1270599, bug 1286250, bug 1286880, bug 1270634, bug 1286878) for multiple perma failures. CLOSED TREE

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66821b7b0179
throw correct error when encrypting with a bad AES-GCM tag length r=keeler

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/66821b7b0179