1286079 - Add support for highlighting multiple lines and initial location

Status: NEW

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Eric Rahm [:erahm]]

Per discussion on dev-platform [1] folks would like the ability to highlight multiple lines.

Excerpt:

> > The annotate (aka blame) functionality of hg.mozilla.org can point at one line
> 
> Yes, I know.  What it can't do is highlight some set of lines containing
> more than one line.  Think things like:
> 
>    http://mxr.mozilla.org/whatever-file?mark=10-20,17,25#8
> 
> which highlights lines 10-20, 17, and 25, and scrolls to line 8.  This
> is very useful when pointing people at code. 

[1] https://groups.google.com/d/msg/mozilla.dev.platform/_k-ditFrne4/1u_-eB10BgAJ

Comment 1

[Masatoshi Kimura [:emk]]

DXR already supports this. For example: https://dxr.mozilla.org/mozilla-central/source/testing/specialpowers/content/specialpowersAPI.js#10-12,14,16

The only missing feature is separating the scroll position from highlights.

Comment 2

[Gregory Szorc [:gps]]

This should be an upstream feature.

If the patch is written in the next 3 days, it can be part of Mercurial 3.9.

I'm not sure I'll have time to write it this week, however.

Comment 3

[Eric Rahm [:erahm]]

(In reply to Masatoshi Kimura [:emk] from comment #1)
> DXR already supports this. For example:
> https://dxr.mozilla.org/mozilla-central/source/testing/specialpowers/content/
> specialpowersAPI.js#10-12,14,16
> 
> The only missing feature is separating the scroll position from highlights.

This request is for mercurial (hg.mozilla.org), I'll file a bug for requesting the scroll position against DXR as well.