[TSF] TSFTextStore should use relative offset query when there are pending changes

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla51
All
Windows
inputmethod
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 affected, firefox51 fixed)

Details

Attachments

(1 attachment)

I realized that TSFTextStore should use relative offset from insertion point query when there are pending changes since the offset of query by TSF/TIP is expected in the cached content.
Created attachment 8770381 [details]
Bug 1286157 TSFTextStore should use insertion point relative offset query when cached contents for TSF and actual content (or content cache) are different

Review commit: https://reviewboard.mozilla.org/r/63842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63842/
Attachment #8770381 - Flags: review?(m_kato)
FYI: I won't land the patch without the fix of bug 1257446 since this patch makes the symptom of bug 1257446 worse.
Status: NEW → ASSIGNED
Comment on attachment 8770381 [details]
Bug 1286157 TSFTextStore should use insertion point relative offset query when cached contents for TSF and actual content (or content cache) are different

https://reviewboard.mozilla.org/r/63842/#review60962
Attachment #8770381 - Flags: review?(m_kato) → review+
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/d8e515832579
TSFTextStore should use insertion point relative offset query when cached contents for TSF and actual content (or content cache) are different r=m_kato

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d8e515832579
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.