Closed Bug 1286159 Opened 4 years ago Closed 4 years ago

Clean up FinishOffThread* APIs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

FinishOffThreadScript and FinishOffThreadModule take both a |JSContext* maybecx| and |JSRuntime* rt|. When maybecx is nullptr, the compilation is discarded and else we create and return the script.

That is subtle and error-prone, and we want to get rid of the JSRuntime* argument, so I'll post a patch to use separate APIs for these cases: FinishOffThreadScript and CancelOffThreadScript.
Attached patch PatchSplinter Review
Jon you're probably most familiar with this code after the module changes..
Attachment #8770047 - Flags: review?(jcoppeard)
Attachment #8770047 - Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/717184f2678e
Clean up FinishOffThread* APIs for off-thread parsing. r=jonco
https://hg.mozilla.org/mozilla-central/rev/717184f2678e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.