Closed
Bug 1286159
Opened 8 years ago
Closed 8 years ago
Clean up FinishOffThread* APIs
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
18.71 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
FinishOffThreadScript and FinishOffThreadModule take both a |JSContext* maybecx| and |JSRuntime* rt|. When maybecx is nullptr, the compilation is discarded and else we create and return the script. That is subtle and error-prone, and we want to get rid of the JSRuntime* argument, so I'll post a patch to use separate APIs for these cases: FinishOffThreadScript and CancelOffThreadScript.
|
Assignee | |
Comment 1•8 years ago
|
||
Jon you're probably most familiar with this code after the module changes..
Attachment #8770047 -
Flags: review?(jcoppeard)
|
||
Updated•8 years ago
|
Attachment #8770047 -
Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/717184f2678e Clean up FinishOffThread* APIs for off-thread parsing. r=jonco
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/717184f2678e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•