[pine => mc] Kill MOZ_CIHLD_PERMISSIONS

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gerard, Assigned: gerard)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8770065 [details]
Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS

Review commit: https://reviewboard.mozilla.org/r/63652/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63652/
Attachment #8770065 - Flags: review?(bzbarsky)
(Assignee)

Updated

2 years ago
Attachment #8770065 - Flags: review?(bzbarsky)
Did you mean to cancel the review request?
Flags: needinfo?(lissyx+mozillians)
(Assignee)

Comment 4

2 years ago
Yep, for now, I though bugzilla was synced with mozreview for this. There are some tests breakages we need to fix before.
Flags: needinfo?(lissyx+mozillians)
(Assignee)

Updated

2 years ago
Depends on: 1286241
(Assignee)

Updated

2 years ago
Depends on: 1286503
(Assignee)

Comment 5

2 years ago
Comment on attachment 8770065 [details]
Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63652/diff/1-2/
Attachment #8770065 - Flags: review?(bzbarsky)
(Assignee)

Updated

2 years ago
Summary: Kill MOZ_CIHLD_PERMISSIONS → [pine => mc] Kill MOZ_CIHLD_PERMISSIONS
(Assignee)

Comment 6

2 years ago
Sorry for the spam, I guess it is ready for review now, the failing tests were on dom/inputmethod which only really makes sense on B2G.
Flags: needinfo?(bzbarsky)
Comment on attachment 8770065 [details]
Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS

https://reviewboard.mozilla.org/r/63652/#review61024

r=me, but we may need followup bugs to get rid of some of these now-always-returning-true "do we have this permission?" methods.
Attachment #8770065 - Flags: review?(bzbarsky) → review+
Flags: needinfo?(bzbarsky)

Comment 8

2 years ago
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11b0b0c47609
Get rid of MOZ_CHILD_PERMISSIONS r=bz
(Assignee)

Updated

2 years ago
Blocks: 1286592
(Assignee)

Comment 9

2 years ago
(In reply to Boris Zbarsky [:bz] from comment #7)
> Comment on attachment 8770065 [details]
> Bug 1286190 - Get rid of MOZ_CHILD_PERMISSIONS
> 
> https://reviewboard.mozilla.org/r/63652/#review61024
> 
> r=me, but we may need followup bugs to get rid of some of these
> now-always-returning-true "do we have this permission?" methods.

Sure, filed as a follow up: bug 1286592.

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/11b0b0c47609
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.