1286348 - Reintroduce support for UNPACK_FLIP_Y and UNPACK_PREMULTIPLY_ALPHA for WebGL2

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1286348 - Reintroduce support for UNPACK_{FLIP_Y,PREMULTIPLY_ALPHA}. -

Review commit: https://reviewboard.mozilla.org/r/63758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63758/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1286348 - Only set ROW_LENGTH if it's different. -

Review commit: https://reviewboard.mozilla.org/r/63760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63760/

Comment 3

[Kelsey Gilbert [:jgilbert]]

These patches are exciting, because:

$ git diff --stat HEAD~2
 dom/canvas/TexUnpackBlob.cpp      | 928 +++++++++++++-------------------------
 dom/canvas/TexUnpackBlob.h        |  82 ++--
 dom/canvas/WebGLContext.h         |  24 +-
 dom/canvas/WebGLContextUtils.cpp  |  18 +-
 dom/canvas/WebGLTexture.h         |   3 +
 dom/canvas/WebGLTextureUpload.cpp | 138 +++---
 6 files changed, 430 insertions(+), 763 deletions(-)

Comment 4

[Kelsey Gilbert [:jgilbert]]

Try is green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=506ab0b35f2a

Comment 5

[Kelsey Gilbert [:jgilbert]]

Well, windows hasn't come back yet, but it was green before. "likely green"

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8770263 [details]
Bug 1286348 - Reintroduce support for UNPACK_{FLIP_Y,PREMULTIPLY_ALPHA}. -

https://reviewboard.mozilla.org/r/63758/#review60938

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8770264 [details]
Bug 1286348 - Only set ROW_LENGTH if it's different. -

https://reviewboard.mozilla.org/r/63760/#review60940

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d95a6d08558
Reintroduce support for UNPACK_{FLIP_Y,PREMULTIPLY_ALPHA}. - r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/b15f05a94c71
Only set ROW_LENGTH if it's different. - r=mtseng

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8d95a6d08558
https://hg.mozilla.org/mozilla-central/rev/b15f05a94c71