1286390 - Source Actor form should include sourceMapURL

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jason Laster [:jlast]]

The sourceMapURL is needed for client-side source map work. The goal is that the source actor form will include the source map's url so that the client can separately fetch the map.

Comment 1

[Jason Laster [:jlast]]

Attachment: sourceMapUrl.patch

Comment 2

[James Long (:jlongster)]

Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Review of attachment 8770304 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! We should uplift this to beta. It's a harmless patch and will allow the new client to work on a few older versions of Firefox.

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4f145898118

Comment 4

[Jason Laster [:jlast]]

Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

Comment 5

[Jason Laster [:jlast]]

[Feature/regressing bug #]: 1286390
[User impact if declined]: Debugger clients will not be able to source map sources.
[Describe test coverage new/current, TreeHerder]: it doesn't need any new test coverage, we don't test form structures.
[Risks and why]: minimal, sourceMapURL is a source field.
[String/UUID change made/needed]: n/a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/25d022b355be
Add sourceMapURL to source actor form. r=jlongster

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/25d022b355be

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Jason, can you tell me which bug introduced this issue?
> [Feature/regressing bug #]: 1286390
is incorrect.

Comment 9

[Jason Laster [:jlast]]

Hi Sylvestre, sorry for the confusion, this isn't a current issue but a feature we hope to add to support client-side source maps.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Thanks for the information.
Unfortunately, this is way too late for 48 as we are the end of the cycle.

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Review of attachment 8770304 [details] [diff] [review]:
-----------------------------------------------------------------

This patch adds support for Source Actor. Let's take it in 49 aurora.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cff908fa53dc