Closed Bug 1286390 Opened 4 years ago Closed 4 years ago

Source Actor form should include sourceMapURL

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox49 fixed, firefox50 fixed)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

()

Details

Attachments

(1 file)

The sourceMapURL is needed for client-side source map work. The goal is that the source actor form will include the source map's url so that the client can separately fetch the map.
Assignee: nobody → jlaster
Attachment #8770304 - Flags: review?(jlong)
Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Review of attachment 8770304 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! We should uplift this to beta. It's a harmless patch and will allow the new client to work on a few older versions of Firefox.
Attachment #8770304 - Flags: review?(jlong) → review+
Priority: -- → P3
Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:
Attachment #8770304 - Flags: approval-mozilla-beta?
Attachment #8770304 - Flags: approval-mozilla-aurora?
Keywords: checkin-needed
[Feature/regressing bug #]: 1286390
[User impact if declined]: Debugger clients will not be able to source map sources.
[Describe test coverage new/current, TreeHerder]: it doesn't need any new test coverage, we don't test form structures.
[Risks and why]: minimal, sourceMapURL is a source field.
[String/UUID change made/needed]: n/a
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/25d022b355be
Add sourceMapURL to source actor form. r=jlongster
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/25d022b355be
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Jason, can you tell me which bug introduced this issue?
> [Feature/regressing bug #]: 1286390
is incorrect.
Flags: needinfo?(jlaster)
Hi Sylvestre, sorry for the confusion, this isn't a current issue but a feature we hope to add to support client-side source maps.
Flags: needinfo?(jlaster)
Thanks for the information.
Unfortunately, this is way too late for 48 as we are the end of the cycle.
Attachment #8770304 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Comment on attachment 8770304 [details] [diff] [review]
sourceMapUrl.patch

Review of attachment 8770304 [details] [diff] [review]:
-----------------------------------------------------------------

This patch adds support for Source Actor. Let's take it in 49 aurora.
Attachment #8770304 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.