Closed Bug 1286530 Opened 3 years ago Closed 3 years ago

[pine => m-c] Cleanup WebIDL from Apps

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox50 fixed)

RESOLVED FIXED
Tracking Status
firefox50 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Keywords: dev-doc-complete)

Attachments

(2 files, 43 obsolete files)

58 bytes, text/x-review-board-request
bzbarsky
: review+
fabrice
: review+
Details
10.13 KB, patch
Details | Diff | Splinter Review
Basically this is about landing all changes from bug 1266035.
Conflicts:
	dom/bindings/BindingUtils.cpp
	dom/bindings/Codegen.py
	dom/bindings/parser/WebIDL.py

Review commit: https://reviewboard.mozilla.org/r/63934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63934/
Attachment #8770532 - Flags: review?(fabrice)
Attachment #8770533 - Flags: review?(fabrice)
Attachment #8770534 - Flags: review?(fabrice)
Attachment #8770535 - Flags: review?(fabrice)
Attachment #8770536 - Flags: review?(fabrice)
Attachment #8770537 - Flags: review?(fabrice)
Attachment #8770538 - Flags: review?(fabrice)
Attachment #8770539 - Flags: review?(fabrice)
Attachment #8770540 - Flags: review?(fabrice)
Attachment #8770541 - Flags: review?(fabrice)
Attachment #8770542 - Flags: review?(fabrice)
Attachment #8770543 - Flags: review?(fabrice)
Attachment #8770544 - Flags: review?(fabrice)
Attachment #8770545 - Flags: review?(fabrice)
Attachment #8770546 - Flags: review?(fabrice)
Attachment #8770547 - Flags: review?(fabrice)
Attachment #8770548 - Flags: review?(fabrice)
Attachment #8770549 - Flags: review?(fabrice)
Attachment #8770550 - Flags: review?(fabrice)
Attachment #8770551 - Flags: review?(fabrice)
Attachment #8770552 - Flags: review?(fabrice)
Attachment #8770553 - Flags: review?(fabrice)
Attachment #8770554 - Flags: review?(fabrice)
Attachment #8770555 - Flags: review?(fabrice)
Attachment #8770556 - Flags: review?(fabrice)
Attachment #8770557 - Flags: review?(fabrice)
Attachment #8770558 - Flags: review?(fabrice)
Attachment #8770559 - Flags: review?(fabrice)
Attachment #8770560 - Flags: review?(fabrice)
Attachment #8770561 - Flags: review?(fabrice)
Attachment #8770562 - Flags: review?(fabrice)
Attachment #8770563 - Flags: review?(fabrice)
Attachment #8770564 - Flags: review?(fabrice)
Attachment #8770565 - Flags: review?(fabrice)
Attachment #8770566 - Flags: review?(fabrice)
Attachment #8770567 - Flags: review?(fabrice)
Attachment #8770568 - Flags: review?(fabrice)
Attachment #8770569 - Flags: review?(fabrice)
Attachment #8770570 - Flags: review?(fabrice)
Conflicts:
	dom/webidl/BrowserElement.webidl

Review commit: https://reviewboard.mozilla.org/r/63960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63960/
Conflicts:
	dom/presentation/tests/mochitest/mochitest.ini
	dom/presentation/tests/mochitest/test_presentation_sender_startWithDevice.html

Review commit: https://reviewboard.mozilla.org/r/63988/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63988/
Conflicts:
	dom/tests/mochitest/geolocation/test_mozsettings.html
	dom/tests/mochitest/geolocation/test_mozsettingsWatch.html

Review commit: https://reviewboard.mozilla.org/r/63994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63994/
Conflicts:
	dom/base/test/mochitest.ini
	dom/base/test/mozbrowser_api_utils.js
	dom/browser-element/mochitest/browserElement_ActiveStateChangeOnChangingMutedOrVolume.js
	dom/browser-element/mochitest/browserElement_getStructuredData.js
	dom/browser-element/mochitest/mochitest.ini
	dom/browser-element/mochitest/priority/mochitest.ini
	dom/browser-element/mochitest/test_browserElement_inproc_ActiveStateChangeOnChangingMutedOrVolume.html
	dom/browser-element/mochitest/test_browserElement_inproc_getStructuredData.html
	dom/browser-element/mochitest/test_browserElement_oop_ActiveStateChangeOnChangingMutedOrVolume.html
	dom/browser-element/moz.build

Review commit: https://reviewboard.mozilla.org/r/63998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63998/
Conflicts:
	dom/browser-element/mochitest/chrome.ini
	dom/browser-element/mochitest/mochitest-oop.ini

Review commit: https://reviewboard.mozilla.org/r/64000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64000/
Conflicts:
	dom/permission/tests/mochitest.ini

Review commit: https://reviewboard.mozilla.org/r/64010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64010/
Conflicts:
	dom/tests/mochitest/notification/mochitest.ini

Review commit: https://reviewboard.mozilla.org/r/64012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64012/
Comment on attachment 8770608 [details]
Bug 1286530 - Switch mozAlarm mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64040/diff/1-2/
Comment on attachment 8770531 [details]
Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63934/diff/1-2/
Comment on attachment 8770532 [details]
Bug 1286530 - Turn WebIDL APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63936/diff/1-2/
Comment on attachment 8770533 [details]
Bug 1286530 - Switch to chrome mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63938/diff/1-2/
Comment on attachment 8770534 [details]
Bug 1286530 - Turn mozAlarms API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63940/diff/1-2/
Comment on attachment 8770535 [details]
Bug 1286530 - Turn mozApps API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63942/diff/1-2/
Comment on attachment 8770536 [details]
Bug 1286530 - Turn Input-related APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63944/diff/1-2/
Comment on attachment 8770537 [details]
Bug 1286530 - Turn Bluetooth-related APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63946/diff/1-2/
Comment on attachment 8770538 [details]
Bug 1286530 - Turn NFC-related APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63948/diff/1-2/
Comment on attachment 8770539 [details]
Bug 1286530 - Turn Download API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63950/diff/1-2/
Comment on attachment 8770540 [details]
Bug 1286530 - Turn Settings API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63952/diff/1-2/
Comment on attachment 8770541 [details]
Bug 1286530 - Turn Contacts API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63954/diff/1-2/
Comment on attachment 8770542 [details]
Bug 1286530 - Turn NetworkStats API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63956/diff/1-2/
Comment on attachment 8770543 [details]
Bug 1286530 - Turn ResourceStats API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63958/diff/1-2/
Comment on attachment 8770544 [details]
Bug 1286530 - Turn BrowserElement API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63960/diff/1-2/
Comment on attachment 8770545 [details]
Bug 1286530 - Turn UDP/TCP Socket APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63962/diff/1-2/
Comment on attachment 8770546 [details]
Bug 1286530 - Turn mozPower API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63964/diff/1-2/
Comment on attachment 8770547 [details]
Bug 1286530 - Turn Feature API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63966/diff/1-2/
Comment on attachment 8770548 [details]
Bug 1286530 - Turn IdleObserver API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63968/diff/1-2/
Comment on attachment 8770549 [details]
Bug 1286530 - Turn mozFMRadio API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63970/diff/1-2/
Comment on attachment 8770550 [details]
Bug 1286530 - Turn mozTime API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63972/diff/1-2/
Comment on attachment 8770551 [details]
Bug 1286530 - Turn SystemUpdate API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63974/diff/1-2/
Comment on attachment 8770552 [details]
Bug 1286530 - Turn AudioChannelManager API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63976/diff/1-2/
Comment on attachment 8770553 [details]
Bug 1286530 - Turn mozChromeNotifications API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63978/diff/1-2/
Comment on attachment 8770554 [details]
Bug 1286530 - Turn mozTetheringManager API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63980/diff/1-2/
Comment on attachment 8770555 [details]
Bug 1286530 - Turn SimplePush API to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63982/diff/1-2/
Comment on attachment 8770556 [details]
Bug 1286530 - Switch RIL-related mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63984/diff/1-2/
Comment on attachment 8770557 [details]
Bug 1286530 - Switch TV-related mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63986/diff/1-2/
Comment on attachment 8770558 [details]
Bug 1286530 - Switch TV-related mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63988/diff/1-2/
Comment on attachment 8770559 [details]
Bug 1286530 - Switch Input-related mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63990/diff/1-2/
Comment on attachment 8770560 [details]
Bug 1286530 - Disable some inputmethod test that are failing

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63992/diff/1-2/
Comment on attachment 8770561 [details]
Bug 1286530 - Switch mozSettings mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63994/diff/1-2/
Comment on attachment 8770562 [details]
Bug 1286530 - Switch Contacts-related mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63996/diff/1-2/
Comment on attachment 8770563 [details]
Bug 1286530 - Switch BrowserElement-related mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63998/diff/1-2/
Comment on attachment 8770564 [details]
Bug 1286530 - Disable some mochitest-oop tests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64000/diff/1-2/
Comment on attachment 8770565 [details]
Bug 1286530 - Switch UDP/TCP Socket mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64002/diff/1-2/
Comment on attachment 8770566 [details]
Bug 1286530 - Switch mozPower mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64004/diff/1-2/
Comment on attachment 8770567 [details]
Bug 1286530 - Switch Feature-related mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64006/diff/1-2/
Comment on attachment 8770568 [details]
Bug 1286530 - Switch IdleObserver mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64008/diff/1-2/
Comment on attachment 8770569 [details]
Bug 1286530 - Disable permissions mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64010/diff/1-2/
Comment on attachment 8770570 [details]
Bug 1286530 - Switch mozChromeNotifications mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64012/diff/1-2/
Comment on attachment 8770608 [details]
Bug 1286530 - Switch mozAlarm mochitests to chrome

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64040/diff/2-3/
Comment on attachment 8770531 [details]
Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63934/diff/2-3/
Attachment #8770531 - Attachment description: Bug 1286530 - Get rid of AvailableIn, CheckAnyPermissions and CheckAllPermissions → Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL
Attachment #8770532 - Attachment description: Bug 1286530 - Turn RIL-related APIs to ChromeOnly → Bug 1286530 - Turn WebIDL APIs to ChromeOnly sr?bz
Attachment #8770533 - Attachment description: Bug 1286530 - Turn TV-related APIs to ChromeOnly → Bug 1286530 - Switch to chrome mochitests
Attachment #8770531 - Flags: review?(bzbarsky)
Comment on attachment 8770532 [details]
Bug 1286530 - Turn WebIDL APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63936/diff/2-3/
Comment on attachment 8770533 [details]
Bug 1286530 - Switch to chrome mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63938/diff/2-3/
Attachment #8770534 - Attachment is obsolete: true
Attachment #8770534 - Flags: review?(fabrice)
Attachment #8770535 - Attachment is obsolete: true
Attachment #8770535 - Flags: review?(fabrice)
Attachment #8770536 - Attachment is obsolete: true
Attachment #8770536 - Flags: review?(fabrice)
Attachment #8770537 - Attachment is obsolete: true
Attachment #8770537 - Flags: review?(fabrice)
Attachment #8770538 - Attachment is obsolete: true
Attachment #8770538 - Flags: review?(fabrice)
Attachment #8770539 - Attachment is obsolete: true
Attachment #8770539 - Flags: review?(fabrice)
Attachment #8770540 - Attachment is obsolete: true
Attachment #8770540 - Flags: review?(fabrice)
Attachment #8770541 - Attachment is obsolete: true
Attachment #8770541 - Flags: review?(fabrice)
Attachment #8770542 - Attachment is obsolete: true
Attachment #8770542 - Flags: review?(fabrice)
Attachment #8770543 - Attachment is obsolete: true
Attachment #8770543 - Flags: review?(fabrice)
Attachment #8770544 - Attachment is obsolete: true
Attachment #8770544 - Flags: review?(fabrice)
Attachment #8770545 - Attachment is obsolete: true
Attachment #8770545 - Flags: review?(fabrice)
Attachment #8770546 - Attachment is obsolete: true
Attachment #8770546 - Flags: review?(fabrice)
Attachment #8770547 - Attachment is obsolete: true
Attachment #8770547 - Flags: review?(fabrice)
Attachment #8770548 - Attachment is obsolete: true
Attachment #8770548 - Flags: review?(fabrice)
Attachment #8770549 - Attachment is obsolete: true
Attachment #8770549 - Flags: review?(fabrice)
Attachment #8770550 - Attachment is obsolete: true
Attachment #8770550 - Flags: review?(fabrice)
Attachment #8770551 - Attachment is obsolete: true
Attachment #8770551 - Flags: review?(fabrice)
Attachment #8770552 - Attachment is obsolete: true
Attachment #8770552 - Flags: review?(fabrice)
Attachment #8770553 - Attachment is obsolete: true
Attachment #8770553 - Flags: review?(fabrice)
Attachment #8770554 - Attachment is obsolete: true
Attachment #8770554 - Flags: review?(fabrice)
Comment on attachment 8770531 [details]
Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63934/diff/3-4/
Comment on attachment 8770532 [details]
Bug 1286530 - Turn WebIDL APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63936/diff/3-4/
Comment on attachment 8770533 [details]
Bug 1286530 - Switch to chrome mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63938/diff/3-4/
Attachment #8770555 - Attachment is obsolete: true
Attachment #8770555 - Flags: review?(fabrice)
Attachment #8770556 - Attachment is obsolete: true
Attachment #8770556 - Flags: review?(fabrice)
Attachment #8770557 - Attachment is obsolete: true
Attachment #8770557 - Flags: review?(fabrice)
Attachment #8770558 - Attachment is obsolete: true
Attachment #8770558 - Flags: review?(fabrice)
Attachment #8770559 - Attachment is obsolete: true
Attachment #8770559 - Flags: review?(fabrice)
Attachment #8770560 - Attachment is obsolete: true
Attachment #8770560 - Flags: review?(fabrice)
Attachment #8770561 - Attachment is obsolete: true
Attachment #8770561 - Flags: review?(fabrice)
Attachment #8770562 - Attachment is obsolete: true
Attachment #8770562 - Flags: review?(fabrice)
Attachment #8770563 - Attachment is obsolete: true
Attachment #8770563 - Flags: review?(fabrice)
Attachment #8770564 - Attachment is obsolete: true
Attachment #8770564 - Flags: review?(fabrice)
Attachment #8770565 - Attachment is obsolete: true
Attachment #8770565 - Flags: review?(fabrice)
Attachment #8770566 - Attachment is obsolete: true
Attachment #8770566 - Flags: review?(fabrice)
Attachment #8770567 - Attachment is obsolete: true
Attachment #8770567 - Flags: review?(fabrice)
Attachment #8770568 - Attachment is obsolete: true
Attachment #8770568 - Flags: review?(fabrice)
Attachment #8770569 - Attachment is obsolete: true
Attachment #8770569 - Flags: review?(fabrice)
Attachment #8770570 - Attachment is obsolete: true
Attachment #8770570 - Flags: review?(fabrice)
Attachment #8770608 - Attachment is obsolete: true
Comment on attachment 8770532 [details]
Bug 1286530 - Turn WebIDL APIs to ChromeOnly

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63936/diff/4-5/
Attachment #8770532 - Attachment description: Bug 1286530 - Turn WebIDL APIs to ChromeOnly sr?bz → Bug 1286530 - Turn WebIDL APIs to ChromeOnly
Attachment #8770532 - Flags: review?(fabrice) → review?(bzbarsky)
Comment on attachment 8770533 [details]
Bug 1286530 - Switch to chrome mochitests

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63938/diff/4-5/
So, Boris, I know you already had an extensive look at this in bug 1266035. This is the final push to central, most of the changes are the same, except as you warned us there were some conflicts :). Hence why asking another look, but hopefully it should be quite fast now.

Also, maybe for the final push it would be better to squash all this into one commit, since otherwise it would break any bisection (either because of WebIDL changes or runtime of mochitests).
Assignee: nobody → lissyx+mozillians
Flags: needinfo?(bzbarsky)
Thanks in advance for your reviewing work!
Attachment #8770533 - Flags: review?(fabrice) → review+
Comment on attachment 8770531 [details]
Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL

https://reviewboard.mozilla.org/r/63934/#review61342

I recall already reviewing all this stuff before.  Why do you need me to review it again?
Attachment #8770531 - Flags: review?(bzbarsky)
Attached patch webidl-1.patch (obsolete) — Splinter Review
Attached patch webidl-2.patch (obsolete) — Splinter Review
and the second version of that same patch
Attachment #8771303 - Attachment is obsolete: true
Comment on attachment 8771304 [details] [diff] [review]
webidl-2.patch

splinter is unable to handle those to produce an interdiff :/
Attachment #8771304 - Attachment is obsolete: true
Attached patch webidl_interdiff.patch (obsolete) — Splinter Review
Comment on attachment 8771344 [details] [diff] [review]
webidl_interdiff.patch

Sorry it's not perfect, but this is the best I have been able to get. Inter-diff generation on SplinterReview refused to work, |interdiff| locally would fail also.

So I generated both patches and then did a |diff -U8 -w| between them.
Flags: needinfo?(bzbarsky)
Attachment #8771344 - Flags: review?(bzbarsky)
Comment on attachment 8770531 [details]
Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63934/diff/4-5/
Attachment #8770531 - Flags: review?(fabrice)
Attachment #8770531 - Flags: review?(bzbarsky)
Attachment #8770532 - Attachment is obsolete: true
Attachment #8770533 - Attachment is obsolete: true
Attachment #8770531 - Flags: review?(fabrice) → review+
Comment on attachment 8770531 [details]
Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL

https://reviewboard.mozilla.org/r/63934/#review61574
Attachment #8771344 - Attachment is obsolete: true
Attachment #8771344 - Flags: review?(bzbarsky)
Comment on attachment 8770531 [details]
Bug 1286530 - Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL

https://reviewboard.mozilla.org/r/63934/#review61620

r=me.  Thanks, the conflict listing was exactly what I needed.
Attachment #8770531 - Flags: review?(bzbarsky) → review+
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20a6fd076505
Clean AvailableIn, CheckAnyPermissions and CheckAllPermissions from WebIDL r=bz,fabrice
https://hg.mozilla.org/mozilla-central/rev/20a6fd076505
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
It looks like this has added mochitest-chrome tests for Android beyond the capacity of those jobs -- Android mochitest-chrome is now regularly failing due to time-outs. I can add capacity (split into more chunks), but want to check first -- do you want to run these tests on Android?
Flags: needinfo?(lissyx+mozillians)
Can you show me which tests ? As far as I can tell, I re-used the test scoping from mochitest.ini
Flags: needinfo?(lissyx+mozillians)
(In reply to Alexandre LISSY :gerard-majax from comment #113)
> Can you show me which tests ? As far as I can tell, I re-used the test
> scoping from mochitest.ini

https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=android%20mochitest%20chrome&tochange=d2021311169e24dc0104854674c4603a8c312bda&fromchange=7592a7157654536adbbe25b244a43cb78e3f7902

We can probably just skip them on Android anyway. I'll provide a patch for this asap.
Depends on: 1287455
You need to log in before you can comment on or make changes to this bug.