Closed Bug 1286553 Opened 3 years ago Closed 3 years ago

Context menu is not visible when clicking outside the color picker popup

Categories

(DevTools :: Inspector, defect, P1)

50 Branch
All
Windows
defect

Tracking

(firefox47 unaffected, firefox48 unaffected, firefox49 unaffected, firefox50 verified)

VERIFIED FIXED
Firefox 50
Iteration:
50.3 - Jul 18
Tracking Status
firefox47 --- unaffected
firefox48 --- unaffected
firefox49 --- unaffected
firefox50 --- verified

People

(Reporter: adalucinet, Assigned: jdescottes)

References

Details

(Keywords: regression, Whiteboard: [reserve-html])

Attachments

(1 file)

[Affected versions]:
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit

[Steps to reproduce]:
1. Launch Firefox.
2. Open Inspector: Ctrl + Shift + C (for Windows & Ubuntu) or Cmd + Opt + C (for Mac OS X)
3. In the CSS Pane's Rules view, click on an color sample.
4. Right click outside the color picker popup.

[Expected result]: The context menu is visible.

[Actual result]: The color picker popup fades away.

[Regression range]:
- Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=679118259e91f40d4a8f968f03ec4cff066cdb5b&tochange=42dcbbe5f18d3f50ec1af613f12bc9cd11dfaf0b
- Found commit message: Bug 1267414 - Convert color picker, cubic bezier and filter widgets to HTML Tooltip. r=jdescottes

[Additional notes]:
- Screen recording: https://goo.gl/7lzd30
QA Whiteboard: [qe-dthtml]
Whiteboard: [devtools-html][triage]
Flags: qe-verify+
QA Contact: alexandra.lucinet
Priority: -- → P2
Whiteboard: [devtools-html][triage] → [reserve-html]
Could not reproduce on OSX, but can confirm the issue occurs on Windows.

Before the migration to the HTMLTooltip, the colorpicker (and other ruleview editors) were setting "consumeoutsideclicks" to true on their XUL panel. However it looks like this was only catching left clicks.

We could modify the behavior of consumeOutsideClicks on the HTMLTooltip to only preventDefault for left click events.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Iteration: --- → 50.3 - Jul 18
Priority: P2 → P1
Attachment #8771396 - Flags: review?(bgrinstead) → review+
Comment on attachment 8771396 [details]
Bug 1286553 - HTMLTooltip: consume only left click events;

https://reviewboard.mozilla.org/r/64582/#review61720

::: devtools/client/shared/widgets/HTMLTooltip.js:494
(Diff revision 1)
>      if (this._isInTooltipContainer(e.target)) {
>        return;
>      }
>  
>      this.hide();
> -    if (this.consumeOutsideClicks) {
> +    if (this.consumeOutsideClicks && e.button === 0) {

Can you add an assertion in browser_html_tooltip-02.js for this?
Comment on attachment 8771396 [details]
Bug 1286553 - HTMLTooltip: consume only left click events;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64582/diff/1-2/
https://reviewboard.mozilla.org/r/64582/#review61720

> Can you add an assertion in browser_html_tooltip-02.js for this?

Thanks for the review, done! try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a2d35046d72
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/76bb0b29a750
HTMLTooltip: consume only left click events;r=bgrins
https://hg.mozilla.org/mozilla-central/rev/76bb0b29a750
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Verified fixed with latest Nightly 50.0a1, under Windows 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.