1286553 - Context menu is not visible when clicking outside the color picker popup

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Ada [:adalucinet]]

[Affected versions]:
- latest Nightly 50.0a1

[Affected platforms]:
- Windows 10 64-bit

[Steps to reproduce]:
1. Launch Firefox.
2. Open Inspector: Ctrl + Shift + C (for Windows & Ubuntu) or Cmd + Opt + C (for Mac OS X)
3. In the CSS Pane's Rules view, click on an color sample.
4. Right click outside the color picker popup.

[Expected result]: The context menu is visible.

[Actual result]: The color picker popup fades away.

[Regression range]:
- Pushlog: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=679118259e91f40d4a8f968f03ec4cff066cdb5b&tochange=42dcbbe5f18d3f50ec1af613f12bc9cd11dfaf0b
- Found commit message: Bug 1267414 - Convert color picker, cubic bezier and filter widgets to HTML Tooltip. r=jdescottes

[Additional notes]:
- Screen recording: https://goo.gl/7lzd30

Comment 1

[Julian Descottes [:jdescottes]]

Could not reproduce on OSX, but can confirm the issue occurs on Windows.

Before the migration to the HTMLTooltip, the colorpicker (and other ruleview editors) were setting "consumeoutsideclicks" to true on their XUL panel. However it looks like this was only catching left clicks.

We could modify the behavior of consumeOutsideClicks on the HTMLTooltip to only preventDefault for left click events.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1286553 - HTMLTooltip: consume only left click events;

Review commit: https://reviewboard.mozilla.org/r/64582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64582/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8771396 [details]
Bug 1286553 - HTMLTooltip: consume only left click events;

https://reviewboard.mozilla.org/r/64582/#review61720

::: devtools/client/shared/widgets/HTMLTooltip.js:494
(Diff revision 1)
>      if (this._isInTooltipContainer(e.target)) {
>        return;
>      }
>  
>      this.hide();
> -    if (this.consumeOutsideClicks) {
> +    if (this.consumeOutsideClicks && e.button === 0) {

Can you add an assertion in browser_html_tooltip-02.js for this?

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8771396 [details]
Bug 1286553 - HTMLTooltip: consume only left click events;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64582/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

https://reviewboard.mozilla.org/r/64582/#review61720

> Can you add an assertion in browser_html_tooltip-02.js for this?

Thanks for the review, done! try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a2d35046d72

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/76bb0b29a750
HTMLTooltip: consume only left click events;r=bgrins

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76bb0b29a750

Comment 8

[Ada [:adalucinet]]

Verified fixed with latest Nightly 50.0a1, under Windows 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.9.5.