Closed Bug 1286554 Opened 7 years ago Closed 6 years ago

Prefs: remove "network.http.keep_empty_response_headers_as_empty_string"

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: wisniewskit, Assigned: wisniewskit)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 2 obsolete files)

Remove network.http.keep_empty_response_headers_as_empty_string
8.59 KB, patch
jduell.mcbugs
: review+
Details | Diff | Splinter Review 
The pref network.http.keep_empty_response_headers_as_empty_string was added in bug 669259 and activated in bug 918721. It can be removed after a release cycle or two if users haven't reported any issues with having it on by default.
Here's a candidate patch for when the time comes.
Assignee: nobody → wisniewskit
Whiteboard: [necko-active]
Dragana says we should land this once firefox 50 lands (and we're sure that the default value of the pref doesn't break anything).
jduell, should we go ahead and remove this pref now?
Flags: needinfo?(jduell.mcbugs)
Attached patch v2 (obsolete) — — Splinter Review 
+r.  Here's an unbitrotted version of the patch.

try run:

   https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb20abbaee4f6177b5a00e0cb14a098fbfa9338f
Attachment #8770603 - Attachment is obsolete: true
Flags: needinfo?(jduell.mcbugs)
Attachment #8882333 - Flags: review+
Comment on attachment 8882333 [details] [diff] [review]
v2

Try run looks problematic:  Lots of WPT tests failing with

   expected (string) "" but got (object) null

Looks like we've got the 'if' condition in SetHeaderFromNet() wrong?  Should that whole block be removed (since IIUC we're always going to be keeping empty headers now)?  Should we also get rid of  nsHttpHeaderArray::TrackEmptyHeader() for the same reason? (no longer need to keep whitelist of headers to always keep empty string for)
Flags: needinfo?(dd.mozilla)
Attachment #8882333 - Flags: review+ → review-
Fixed it. Try looks good now
Attachment #8894071 - Flags: review?(jduell.mcbugs)
Attachment #8882333 - Attachment is obsolete: true
Flags: needinfo?(dd.mozilla)
Attachment #8894071 - Flags: review?(jduell.mcbugs) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a886c2a428f6
Remove network.http.keep_empty_response_headers_as_empty_string. r=jduell
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a886c2a428f6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.