1286627 - about:preferences#general broken with --disable-gio since 46.0

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[Jan Beich]

Attachment: general.png

Opening Preferences shows General tab full of empty fields for a wrong tab. Trying to switch away and back fails as General tab doesn't refresh. Browser Console has the following lines:

  Error initializing preference category paneGeneral: TypeError: target.shellService is undefined
  TypeError: target.shellService is undefined

Backing out bug 1238712 helps, so does dropping --disable-gio from .mozconfig.

Comment 1

[Jan Beich]

On Firefox 48 and higher this bug while still present is shadowed by bug 1287288.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

jaws, can you take a look here at what broke FreeBSD's builds?  Maybe not for the beta 49 timeframe, but if we intend to fix this then I'd like to stop triaging it during every beta and aim for a particular release version. Thanks!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1286627 - Check for undefined shell service before dereferencing it in the ShellService proxy. Linux builds that disable gio do not have the shell service defined and the proxy was throwing.

Review commit: https://reviewboard.mozilla.org/r/73450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73450/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1287288#c9 we may kill the --disable-gio option, but it wouldn't hurt to make this code change anyways.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8783761 [details]
Bug 1286627 - Check for undefined shell service before dereferencing it in the ShellService proxy. Linux builds that disable gio do not have the shell service defined and the proxy was throwing.

https://reviewboard.mozilla.org/r/73450/#review71360

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a759a1704791
Check for undefined shell service before dereferencing it in the ShellService proxy. Linux builds that disable gio do not have the shell service defined and the proxy was throwing. r=Gijs

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a759a1704791

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Jan, can you test that the change in this bug fixes your build for you?

Comment 9

[Jan Beich]

I confirm, a759a1704791 fixes both comment 0 (here) and bug 1287288 comment 0.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Thanks Jan, sorry for taking so long on this.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8783761 [details]
Bug 1286627 - Check for undefined shell service before dereferencing it in the ShellService proxy. Linux builds that disable gio do not have the shell service defined and the proxy was throwing.

Approval Request Comment
[Feature/regressing bug #]: bug 1238712
[User impact if declined]: Firefox crashes on startup when built with --disable-gio. We can drop support for --disable-gio going forward but as it stands now it would be a good idea to uplift this to fix the other branches.
[Describe test coverage new/current, TreeHerder]: Landed on central for a few days and verified by bug reporter.
[Risks and why]: none expected
[String/UUID change made/needed]: none

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8783761 [details]
Bug 1286627 - Check for undefined shell service before dereferencing it in the ShellService proxy. Linux builds that disable gio do not have the shell service defined and the proxy was throwing.

Fixes a regression, Aurora50+

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c66cc1b3d227

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8783761 [details]
Bug 1286627 - Check for undefined shell service before dereferencing it in the ShellService proxy. Linux builds that disable gio do not have the shell service defined and the proxy was throwing.

Verified fix for build regression, sounds good to me.
Thanks for fixing and testing everyone! This should be in the 49 beta 9 build.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7a113ada69fe