Closed Bug 1286650 Opened 3 years ago Closed 3 years ago

Allow explicit specification of an API key in scripts/issue-api-key.pl

Categories

(bugzilla.mozilla.org :: Continous Integration, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

Details

Attachments

(1 file)

Since login cookies will be going away in BMO after the upstream merge is complete, MozReview's auth system as used in testing will have to change to using API keys.  This will be much easier if we can use a known API key, rather than a random one that we have to temporarily store somewhere.  Since issue-api-key.pl was written specifically for testing, I think it makes sense to add this functionality.
Attached patch Patch, v1Splinter Review
Attachment #8770694 - Flags: review?(dylan)
Comment on attachment 8770694 [details] [diff] [review]
Patch, v1

Review of attachment 8770694 [details] [diff] [review]:
-----------------------------------------------------------------

remove the no warnings, fix on commit.

r=dylan

::: Bugzilla/User/APIKey.pm
@@ +90,5 @@
>  }
> +
> +sub create_special {
> +    my ($class, @args) = @_;
> +    no warnings 'redefine';

the no warnings can be removed since we're just localizing a hash thiing.
Attachment #8770694 - Flags: review?(dylan) → review+
https://github.com/mozilla-bteam/bmo/commit/3c3b40c618586c8cbc9cf62d162b6c08b82bf0c6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.