1286700 - Reps: text-node.js cropMultipleLines is undefined

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

In devtools/client/shared/components/reps/text-node.js , the `cropMultipleLines` function is imported from string.js : 
`const { cropMultipleLines } = require("./string");`

But the function is exported from devtools/client/shared/components/reps/rep-utils.js .
The function should be imported from the correct file to fix the error.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1286700 - Reps: Fix function import in text-node.js .

Import `cropMultipleLines` function from the correct file.
Add a test for the TextNode Rep.

Review commit: https://reviewboard.mozilla.org/r/64204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64204/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8770887 [details]
Bug 1286700 - Reps: Fix function import in text-node.js .

https://reviewboard.mozilla.org/r/64204/#review61270

Looks nice!

R+, but please resolve the one comment I've made.

Thanks,
Honza

::: devtools/client/shared/components/test/mochitest/test_reps_text-node.html:22
(Diff revision 1)
> +"use strict";
> +
> +window.onload = Task.async(function* () {
> +  try {
> +    let ReactDOM = browserRequire("devtools/client/shared/vendor/react-dom");
> +    let React = browserRequire("devtools/client/shared/vendor/react");

You can remove React and ReactDOM dependencies.

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8770887 [details]
Bug 1286700 - Reps: Fix function import in text-node.js .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64204/diff/1-2/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

TRY seems fine except an unrelated failure https://treeherder.mozilla.org/#/jobs?repo=try&revision=358c7b707bdd&selectedJob=23906397 , seen on other TRY without this patch

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yeah, it's unrelated (that was actually caused by my patch :)

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c49f826bb58e
Reps: Fix function import in text-node.js. r=Honza

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c49f826bb58e