[MSE] add support for live seekable attribute.

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

Trunk
mozilla50
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
This was added to the MSE spec in Issue 5
(Assignee)

Comment 1

2 years ago
Created attachment 8770821 [details]
Bug 1286723: [MSE] P1. Add support for live seekable attribute.

See https://github.com/w3c/media-source/issues/5

Review commit: https://reviewboard.mozilla.org/r/64154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64154/
Attachment #8770821 - Flags: review?(gsquelart)
Attachment #8770821 - Flags: review?(bzbarsky)
Attachment #8770822 - Flags: review?(gsquelart)
(Assignee)

Comment 2

2 years ago
Created attachment 8770822 [details]
Bug 1286723: [MSE] P2. Add live seekable mochitest.

Review commit: https://reviewboard.mozilla.org/r/64156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64156/
Assignee: nobody → jyavenard
Comment on attachment 8770821 [details]
Bug 1286723: [MSE] P1. Add support for live seekable attribute.

https://reviewboard.mozilla.org/r/64154/#review61192
Attachment #8770821 - Flags: review?(gsquelart) → review+
Comment on attachment 8770822 [details]
Bug 1286723: [MSE] P2. Add live seekable mochitest.

https://reviewboard.mozilla.org/r/64156/#review61194

r+ with typo fixed:

::: dom/media/mediasource/test/test_LiveSeekable.html:18
(Diff revision 1)
> +SimpleTest.waitForExplicitFinish();
> +
> +runWithMSE(function (ms, v) {
> +  ms.addEventListener("sourceopen", function () {
> +    var sb = ms.addSourceBuffer("video/webm");
> +    // Load data with a +2 offset so that we can distinguist buffered range start

'distinguist' -> 'distinguish'

Would it be useful to also test some other cases? E.g.:
- start < 0, start > end (errors)
- start > buffered.end, end < buffered.start (distinct buffered&seekable ranges)
- clearLiveSeekableRange
- Calling set/clearLiveSeekableRange at bad times
Attachment #8770822 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 5

2 years ago
Comment on attachment 8770821 [details]
Bug 1286723: [MSE] P1. Add support for live seekable attribute.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64154/diff/1-2/
(Assignee)

Comment 6

2 years ago
Comment on attachment 8770822 [details]
Bug 1286723: [MSE] P2. Add live seekable mochitest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64156/diff/1-2/
Comment on attachment 8770821 [details]
Bug 1286723: [MSE] P1. Add support for live seekable attribute.

https://reviewboard.mozilla.org/r/64154/#review61334

r=me
Attachment #8770821 - Flags: review?(bzbarsky) → review+

Comment 9

2 years ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcb130529e82
[MSE] P1. Add support for live seekable attribute. r=bz,gerald
https://hg.mozilla.org/integration/autoland/rev/a9bcf6959e2a
[MSE] P2. Add live seekable mochitest. r=gerald
(Assignee)

Updated

2 years ago
Blocks: 1287244

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fcb130529e82
https://hg.mozilla.org/mozilla-central/rev/a9bcf6959e2a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.