1286723 - [MSE] add support for live seekable attribute.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

This was added to the MSE spec in Issue 5

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1286723: [MSE] P1. Add support for live seekable attribute.

See https://github.com/w3c/media-source/issues/5

Review commit: https://reviewboard.mozilla.org/r/64154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64154/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1286723: [MSE] P2. Add live seekable mochitest.

Review commit: https://reviewboard.mozilla.org/r/64156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64156/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8770821 [details]
Bug 1286723: [MSE] P1. Add support for live seekable attribute.

https://reviewboard.mozilla.org/r/64154/#review61192

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8770822 [details]
Bug 1286723: [MSE] P2. Add live seekable mochitest.

https://reviewboard.mozilla.org/r/64156/#review61194

r+ with typo fixed:

::: dom/media/mediasource/test/test_LiveSeekable.html:18
(Diff revision 1)
> +SimpleTest.waitForExplicitFinish();
> +
> +runWithMSE(function (ms, v) {
> +  ms.addEventListener("sourceopen", function () {
> +    var sb = ms.addSourceBuffer("video/webm");
> +    // Load data with a +2 offset so that we can distinguist buffered range start

'distinguist' -> 'distinguish'

Would it be useful to also test some other cases? E.g.:
- start < 0, start > end (errors)
- start > buffered.end, end < buffered.start (distinct buffered&seekable ranges)
- clearLiveSeekableRange
- Calling set/clearLiveSeekableRange at bad times

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8770821 [details]
Bug 1286723: [MSE] P1. Add support for live seekable attribute.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64154/diff/1-2/

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8770822 [details]
Bug 1286723: [MSE] P2. Add live seekable mochitest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64156/diff/1-2/

Comment 7

[Jean-Yves Avenard [:jya]]

https://reviewboard.mozilla.org/r/64156/#review61194

done

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8770821 [details]
Bug 1286723: [MSE] P1. Add support for live seekable attribute.

https://reviewboard.mozilla.org/r/64154/#review61334

r=me

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcb130529e82
[MSE] P1. Add support for live seekable attribute. r=bz,gerald
https://hg.mozilla.org/integration/autoland/rev/a9bcf6959e2a
[MSE] P2. Add live seekable mochitest. r=gerald

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcb130529e82
https://hg.mozilla.org/mozilla-central/rev/a9bcf6959e2a