1286795 - Rename JS_NewRuntime to JS_NewContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

If we do this, most embedders no longer have to care about JSRuntime.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Make more GC APIs take JSContext

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Make JS_RequestInterruptCallback take JSContext

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 3 - Make UbiNode APIs take JSContext

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Part 4 - GC callbacks

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Part 5 - GC classes

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Part 6 - Rename JS_NewRuntime to JS_NewContext

I renamed some related classes from *JSRuntime to *JSContext.

I didn't rename CycleCollectedJSRuntime, XPCJSRuntime, WorkerJSRuntime yet, I can do that as a followup.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8770945 [details] [diff] [review]
Part 6 - Rename JS_NewRuntime to JS_NewContext

r=me but it might be worth talking about the naming of some of this stuff more widely... esp for CycleCollectedJSRuntime and company.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/083f8587e25b
part 1 - Change more GC APIs to take JSContext instead of JSRuntime. r=terrence
https://hg.mozilla.org/integration/mozilla-inbound/rev/8499aa209426
part 2 - Change JS_RequestInterruptCallback to take JSContext instead of JSRuntime. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a92c2516554
part 3 - Change UbiNode APIs to take JSContext instead of JSRuntime. r=fitzgen
https://hg.mozilla.org/integration/mozilla-inbound/rev/beeb4bc99662
part 4 - Change some callbacks to take JSContext instead of JSRuntime. r=terrence
https://hg.mozilla.org/integration/mozilla-inbound/rev/8de5b989cb82
part 5 - Change some classes to take JSContext instead of JSRuntime. r=terrence
https://hg.mozilla.org/integration/mozilla-inbound/rev/64b87ac9b20b
part 6 - Replace JS_NewRuntime/JS_DestroyRuntime with JS_NewContext/JS_DestroyContext. r=luke,bz

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/083f8587e25b
https://hg.mozilla.org/mozilla-central/rev/8499aa209426
https://hg.mozilla.org/mozilla-central/rev/6a92c2516554
https://hg.mozilla.org/mozilla-central/rev/beeb4bc99662
https://hg.mozilla.org/mozilla-central/rev/8de5b989cb82
https://hg.mozilla.org/mozilla-central/rev/64b87ac9b20b