Closed Bug 1286795 Opened 3 years ago Closed 3 years ago

Rename JS_NewRuntime to JS_NewContext

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(6 files)

If we do this, most embedders no longer have to care about JSRuntime.
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Attachment #8770896 - Flags: review?(terrence)
Attachment #8770898 - Flags: review?(nfitzgerald)
Attachment #8770900 - Flags: review?(terrence)
Attachment #8770901 - Flags: review?(terrence)
I renamed some related classes from *JSRuntime to *JSContext.

I didn't rename CycleCollectedJSRuntime, XPCJSRuntime, WorkerJSRuntime yet, I can do that as a followup.
Attachment #8770945 - Flags: review?(luke)
Attachment #8770945 - Flags: review?(bzbarsky)
Attachment #8770897 - Flags: review?(luke) → review+
Attachment #8770945 - Flags: review?(luke) → review+
Attachment #8770896 - Flags: review?(terrence) → review+
Attachment #8770900 - Flags: review?(terrence) → review+
Attachment #8770901 - Flags: review?(terrence) → review+
Comment on attachment 8770945 [details] [diff] [review]
Part 6 - Rename JS_NewRuntime to JS_NewContext

r=me but it might be worth talking about the naming of some of this stuff more widely... esp for CycleCollectedJSRuntime and company.
Attachment #8770945 - Flags: review?(bzbarsky) → review+
Attachment #8770898 - Flags: review?(nfitzgerald) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/083f8587e25b
part 1 - Change more GC APIs to take JSContext instead of JSRuntime. r=terrence
https://hg.mozilla.org/integration/mozilla-inbound/rev/8499aa209426
part 2 - Change JS_RequestInterruptCallback to take JSContext instead of JSRuntime. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a92c2516554
part 3 - Change UbiNode APIs to take JSContext instead of JSRuntime. r=fitzgen
https://hg.mozilla.org/integration/mozilla-inbound/rev/beeb4bc99662
part 4 - Change some callbacks to take JSContext instead of JSRuntime. r=terrence
https://hg.mozilla.org/integration/mozilla-inbound/rev/8de5b989cb82
part 5 - Change some classes to take JSContext instead of JSRuntime. r=terrence
https://hg.mozilla.org/integration/mozilla-inbound/rev/64b87ac9b20b
part 6 - Replace JS_NewRuntime/JS_DestroyRuntime with JS_NewContext/JS_DestroyContext. r=luke,bz
You need to log in before you can comment on or make changes to this bug.