[MSE] Replace various InvalidAccessError with TypeError

RESOLVED FIXED in Firefox 50

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

Trunk
mozilla50
Points:
---

Firefox Tracking Flags

(firefox50 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

a year ago
In the MSE spec (https://github.com/w3c/media-source/issues/34) InvalidAccess/InvalidState was replaced by TypeError.

Should follow the updated specs.
(Assignee)

Updated

a year ago
Blocks: 778617
(Assignee)

Updated

a year ago
Assignee: nobody → jyavenard
(Assignee)

Updated

a year ago
Summary: [MSE] Replace various InvalidStateError with TypeError → [MSE] Replace various InvalidAccessError with TypeError
(Assignee)

Comment 1

a year ago
Created attachment 8770912 [details]
Bug 1286796: [MSE] P1. Replace InvalidAccessError usage with TypeError.

See https://github.com/w3c/media-source/issues/34

Review commit: https://reviewboard.mozilla.org/r/64228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64228/
Attachment #8770912 - Flags: review?(gsquelart)
Attachment #8770913 - Flags: review?(james)
(Assignee)

Comment 2

a year ago
Created attachment 8770913 [details]
Bug 1286796: [MSE] P2. Update InvalidAccessError with TypeError.

As per https://github.com/w3c/media-source/issues/34

Review commit: https://reviewboard.mozilla.org/r/64230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64230/
Comment on attachment 8770913 [details]
Bug 1286796: [MSE] P2. Update InvalidAccessError with TypeError.

https://reviewboard.mozilla.org/r/64230/#review61252
Attachment #8770913 - Flags: review?(james) → review+
Comment on attachment 8770912 [details]
Bug 1286796: [MSE] P1. Replace InvalidAccessError usage with TypeError.

https://reviewboard.mozilla.org/r/64228/#review61266
Attachment #8770912 - Flags: review?(gsquelart) → review+

Comment 5

a year ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38a0ffc8a956
[MSE] P1. Replace InvalidAccessError usage with TypeError. r=gerald
https://hg.mozilla.org/integration/autoland/rev/2a0bf45d5028
[MSE] P2. Update InvalidAccessError with TypeError. r=jgraham

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/38a0ffc8a956
https://hg.mozilla.org/mozilla-central/rev/2a0bf45d5028
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.