Closed Bug 1286822 Opened 10 years ago Closed 11 months ago

Remove disabled beforescriptexecute/afterscriptexecute implementation

Categories

(Core :: DOM: Core & HTML, task, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
146 Branch
Tracking Flags:
Tracking Status
firefox146 --- fixed

People

(Reporter: Ms2ger, Assigned: mathew.hodson)

References

(Blocks 1 open bug)

Details

(Keywords: addon-compat, dev-doc-complete, site-compat)

Attachments

(2 files, 1 obsolete file)

Bug 1286822 - Remove beforescriptexecute/afterscriptexecute events r=emilio
48 bytes, text/x-phabricator-request
Details | Review
Bug 1286822 - Regenerate use_counter_metrics.yaml r=emilio
48 bytes, text/x-phabricator-request
Details | Review
https://github.com/whatwg/html/issues/943
Blocks: 890854
Priority: -- → P3
No no no no no no! I'm an addon user and some of my addons heavily relies on this! If you remove this, some very important functionality will break! Don't remove it! If you do, I will immediately create a fork of Firefox with this feature enabled again, no matter how much effort it will take!
Please don't remove those, the reason I use firefox is extensions and the extensions I use require this to work.
If it's needed only for extensions, perhaps we could keep it for extensions. I understand we're not currently aiming for the same degree of interoperability for extensions as for the web as a whole. (Hopefully this will change as WebExtensions progress.) We shouldn't expose it to the web if it's not standard.
Component: DOM → DOM: Core & HTML
Type: defect → task
Severity: normal → S3
See Also: → 1584269
Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1584269
Resolution: --- → DUPLICATE
See Also: 1584269 →

I uploaded patches to remove the implementation for these events, but I'll wait until they have been disabled by default for a release.

Status: RESOLVED → UNCONFIRMED
Depends on: 1584269
No longer duplicate of bug: 1584269
Ever confirmed: false
Resolution: DUPLICATE → ---
Assignee: nobody → mathew.hodson
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Summary: Remove beforescriptexecute/afterscriptexecute → Remove disabled beforescriptexecute/afterscriptexecute implementation
Attachment #9513092 - Attachment is obsolete: true
Attachment #9513090 - Attachment description: WIP: Bug 1286822 - Remove beforescriptexecute/afterscriptexecute events → Bug 1286822 - Remove beforescriptexecute/afterscriptexecute events
Attachment #9513091 - Attachment description: WIP: Bug 1286822 - Regenerate use_counter_metrics.yaml → Bug 1286822 - Regenerate use_counter_metrics.yaml
Attachment #9513090 - Attachment description: Bug 1286822 - Remove beforescriptexecute/afterscriptexecute events → Bug 1286822 - Remove beforescriptexecute/afterscriptexecute events r=emilio
Attachment #9513091 - Attachment description: Bug 1286822 - Regenerate use_counter_metrics.yaml → Bug 1286822 - Regenerate use_counter_metrics.yaml r=emilio

https://hg.mozilla.org/mozilla-central/rev/826fc4d3174f

Status: ASSIGNED → RESOLVED
Closed: 1 year ago → 11 months ago
status-firefox146: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 146 Branch

Can you land the patch to update the use counters?

Flags: needinfo?(emilio)

Sorry for missing that!

Flags: needinfo?(emilio)

Thank you!

QA Whiteboard: [qa-triage-done-c147/b146]

FF146 MDN work for this can be tracked in https://github.com/mdn/content/issues/41869. Actually there is no work - the interfaces were effectively removed in FF144 so there is nothing in MDN to do.

Keywords: dev-doc-needed → dev-doc-complete
Regressions: 2042907
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: