Closed Bug 1287005 Opened 4 years ago Closed 3 years ago

Normalize C++ line endings

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file, 11 obsolete files)

58 bytes, text/x-review-board-request
fitzgen
: review+
Details
There are a few hundred C/C++ files in tree with CRLF line endings. Let's normalize them.
Review commit: https://reviewboard.mozilla.org/r/64428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64428/
Attachment #8771179 - Flags: review?(khuey)
Attachment #8771180 - Flags: review?(jmuizelaar)
Attachment #8771181 - Flags: review?(jmuizelaar)
Attachment #8771182 - Flags: review?(jmuizelaar)
Attachment #8771183 - Flags: review?(rjesup)
Attachment #8771184 - Flags: review?(gpascutto)
Attachment #8771185 - Flags: review?(mh+mozilla)
Attachment #8771186 - Flags: review?(bgirard)
Attachment #8771187 - Flags: review?(mh+mozilla)
Looks like this entire library was checked in with Windows line
endings :/

Review commit: https://reviewboard.mozilla.org/r/64432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64432/
Review commit: https://reviewboard.mozilla.org/r/64448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/64448/
Attachment #8771189 - Flags: review?(jaws)
Attachment #8771190 - Flags: review?(nfitzgerald)
Attachment #8771188 - Flags: review?(jmathies)
Comment on attachment 8771188 [details]
Bug 1287005 - Normalize line endings in embedding/;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64446/diff/1-2/
Comment on attachment 8771186 [details]
Bug 1287005 - Normalize line endings in IntelPowerGadget.cpp;

https://reviewboard.mozilla.org/r/64442/#review61398
Attachment #8771186 - Flags: review?(bgirard) → review+
Attachment #8771185 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8771187 [details]
Bug 1287005 - Normalize line endings in build/;

https://reviewboard.mozilla.org/r/64444/#review61402

That's third party code... which, btw,we might be able to remove, now.
Attachment #8771187 - Flags: review?(mh+mozilla) → review-
Comment on attachment 8771183 [details]
Bug 1287005 - Normalize line endings in media/;

https://reviewboard.mozilla.org/r/64436/#review61404

All those are third-party.
Attachment #8771183 - Flags: review-
Comment on attachment 8771181 [details]
Bug 1287005 - Normalize line endings in gfx/angle;

https://reviewboard.mozilla.org/r/64432/#review61406

angle is third party.
Attachment #8771181 - Flags: review-
When doing things like this, you should check tools/rewriting/ThirdPartyPaths.txt and exclude the directories it contains.
https://reviewboard.mozilla.org/r/64432/#review61406

I assumed this was caused by someone copying files from a Git checkout on Windows (which uses CRLF in the working directory by default). But I cloned the upstream Git repo and it appears these files are checked into Git with CRLF line endings. Wat.
Attachment #8771180 - Flags: review?(jmuizelaar) → review-
Comment on attachment 8771180 [details]
Bug 1287005 - Normalize line endings in gfx/2d;

https://reviewboard.mozilla.org/r/64430/#review61438

These are generated files.
Attachment #8771182 - Flags: review?(jmuizelaar) → review-
Comment on attachment 8771182 [details]
Bug 1287005 - Normalize line endings for rest of gfx/;

https://reviewboard.mozilla.org/r/64434/#review61440

The *Shaders* files are generated. They should be excluded.
Comment on attachment 8771183 [details]
Bug 1287005 - Normalize line endings in media/;

https://reviewboard.mozilla.org/r/64436/#review61450

All of the media/webrtc/trunk/tools files appear to also be in upstream git with CRLF's.  The other files are also all apparently upstream files; I haven't checked the repos (partly because I'd need to research where they're imported from) but I presume similar status for them from context.
Attachment #8771183 - Flags: review?(rjesup) → review-
Attachment #8771184 - Flags: review?(gpascutto) → review+
ReviewBoard diffs are broken for these patches, filed 1287062.
Comment on attachment 8771188 [details]
Bug 1287005 - Normalize line endings in embedding/;

https://reviewboard.mozilla.org/r/64446/#review61594
Attachment #8771188 - Flags: review?(jmathies) → review+
Attachment #8771181 - Flags: review?(jmuizelaar) → review-
Comment on attachment 8771190 [details]
Bug 1287005 - Normalize line endings in devtools/;

https://reviewboard.mozilla.org/r/64450/#review61642
Attachment #8771190 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8771179 [details]
Bug 1287005 - Normalize line endings in dom/;

This isn't really DOM code.
Attachment #8771179 - Flags: review?(khuey) → review?(jyavenard)
Attachment #8771179 - Flags: review?(jyavenard) → review+
After dropping commits with r- and rebasing, not many changes from this series remain. I'll land whats left shortly.
Attachment #8771179 - Attachment is obsolete: true
Attachment #8771180 - Attachment is obsolete: true
Attachment #8771181 - Attachment is obsolete: true
Attachment #8771182 - Attachment is obsolete: true
Attachment #8771183 - Attachment is obsolete: true
Attachment #8771184 - Attachment is obsolete: true
Attachment #8771185 - Attachment is obsolete: true
Attachment #8771186 - Attachment is obsolete: true
Attachment #8771187 - Attachment is obsolete: true
Attachment #8771188 - Attachment is obsolete: true
Attachment #8771189 - Attachment is obsolete: true
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49fbd8da1b0e
Normalize line endings in devtools/; r=fitzgen
https://hg.mozilla.org/mozilla-central/rev/49fbd8da1b0e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.