1287010 - Some API methods need to run locally with OOP webextensions

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Some API methods should run in the extension process rather than the main process. Examples:

chrome.extension.getViews
chrome.extension.getBackgroundPage
chrome.extension.getURL
chrome.extension.getExtensionTabs
chrome.runtime.getManifest

Generally anything that returns data directly rather than via a callback needs to be handled in this way. I think we'll need to update our schemas to say where the code for an API should run and then have some mechanism for intercepting these special calls in the extension process.

Comment 1

[Rob Wu [:robwu]]

Taking this.

This blocks bug 1287007, because in order to move APIs over to childmanager, the implementation has to be split in two parts (one that always runs locally, and one that may run remotely).

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Use minimal global scope for ext-*.js scripts

Currently there is a tight coupling between registered APIs because they
share the same global scope, and the dependencies between the modules
that use these globals are not explicit. Consequently, it would be
possible for APIs to break when the registered APIs run in separate
processes, because then there are separate global scopes.
To mitigate this issue, this patch isolates the global namespaces of
API registrations in different environments, starting with the "chrome"
process. Content and addon processes will follow later.

A new JSM is introduced to avoid hidden dependencies between ext-*.js
and the script loader. ExtensionUtils.jsm would be a natural choice for
this shared utility method, but cannot be used because its local
`EventEmitter` implementation conflicts with the `EventEmitter` import
in ext-tabs.js.

So, this patch provides isolation of global variables declared through
`globals.XXX = ...`, but does not provide isolation for `Cu.import`-ed
logic. Ideally `Cu.import` should always use its second argument to
prevent inadvertent namespace pollution.

Review commit: https://reviewboard.mozilla.org/r/73152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73152/

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Add pathObj parameter to Schemas

Local wrappers currently look up the API object over and over again
whenever a schema API is invoked. This can be optimized by re-using
the lookup result from a `shouldInject` invocation, which is passed
as the `pathObj` parameter to the wrapper methods.

This commit adds the necessary changes and tests to allow this to
happen, but does not modify the wrapper in Extension.jsm yet.

Also, this construction allows the `ChildAPIManager` to use a local
implementation if available and fall back to a remote implementation
otherwise.

Review commit: https://reviewboard.mozilla.org/r/73154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73154/

Comment 4

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Make environment of Context explicit.

- Add `envType` to BaseContext.
 - Pass an explicit envType to all `registerSchemaAPI` invocations.
 - The factories passed to `registerSchemaAPI` will be split up later, so
   that content scripts (`content_child`) and addon pages can share
   common implementations.
 - The factories that implement the addon API will also be split up,
   to separate code running in the main process (`addon_parent`) from
   code running in a child process (`addon_child`).
 - Remove the use of a hardcoded list of `namespaces` from ProxyContext.
   Now `envType` is used to specify whether an API should be activated.

Review commit: https://reviewboard.mozilla.org/r/73156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73156/

Comment 5

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Move Management logic to SchemaAPIManager

- Moved Management logic to ExtensionUtils (as SchemaAPIManager) so that
  the logic can be used by addon and content processes.
- Remove the `context.extension.hasPermission(api.permission)` check in
  `generateAPIs` because the only user (`registeredPrivilegedAPI`) was
  removed before in bug 1295082.
- Add new category "webextension-scripts-content", intended for
  registering the few scripts that must be loaded in a content process.

Review commit: https://reviewboard.mozilla.org/r/73158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73158/

Comment 6

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Prepare for moving content script APIs to schemas

- By default, schema APIs are not injected in content scripts unless
  the JSON schema sets the "restrictions" attribute to `["content"]`.
- Added the "restrictions" attribute to the storage and test schemas.
  Other APIs will follow in subsequent commits and make use of the
  primitives introduced in this commit.

Review commit: https://reviewboard.mozilla.org/r/73160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73160/

Comment 7

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Use schema-generated i18n for all contexts

Use schema-generated i18n API for both content script and
addon contexts, instead of just the addon context.

Review commit: https://reviewboard.mozilla.org/r/73162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73162/

Comment 8

[Rob Wu [:robwu]]

Attachment: Bug 1287010, 1286712 - Use schema-generated runtime API, split ext-runtime.js

- Use schema-generated runtime API for content scripts instead of
  untyped API.
- Move logic that cannot be run in the main process to a new file.

Together with the previous patch that migrated the i18n API, this
concludes the fix for bug 1286712.

Review commit: https://reviewboard.mozilla.org/r/73164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73164/

Comment 9

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Use schema-generated extension, split ext-extension.js

- This was the last non-schema-generated API in content scripts.

Review commit: https://reviewboard.mozilla.org/r/73166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73166/

Comment 10

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Extension.jsm optimization: Use pathObj

The API implementation is already available upfront when the schema API
is generated, so `pathObj` has the implementation and can be used
instead of looking up the implementation over and over again with
`findPathInObject`.

Review commit: https://reviewboard.mozilla.org/r/73168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73168/

Comment 11

[Rob Wu [:robwu]]

Comment on attachment 8783245 [details]
Bug 1287010 - Use minimal global scope for ext-*.js scripts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73152/diff/1-2/

Comment 12

[Rob Wu [:robwu]]

Comment on attachment 8783246 [details]
Bug 1287010 - Add pathObj parameter to Schemas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73154/diff/1-2/

Comment 13

[Rob Wu [:robwu]]

Comment on attachment 8783247 [details]
Bug 1287010 - Make environment of Context explicit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73156/diff/1-2/

Comment 14

[Rob Wu [:robwu]]

Comment on attachment 8783248 [details]
Bug 1287010 - Move Management logic to SchemaAPIManager

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73158/diff/1-2/

Comment 15

[Rob Wu [:robwu]]

Comment on attachment 8783249 [details]
Bug 1287010 - Prepare for moving content script APIs to schemas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73160/diff/1-2/

Comment 16

[Rob Wu [:robwu]]

Comment on attachment 8783250 [details]
Bug 1287010 - Use schema-generated i18n for all contexts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73162/diff/1-2/

Comment 17

[Rob Wu [:robwu]]

Comment on attachment 8783251 [details]
Bug 1287010, 1286712 - Use schema-generated runtime API, split ext-runtime.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73164/diff/1-2/

Comment 18

[Rob Wu [:robwu]]

Comment on attachment 8783252 [details]
Bug 1287010 - Use schema-generated extension, split ext-extension.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73166/diff/1-2/

Comment 19

[Rob Wu [:robwu]]

Comment on attachment 8783253 [details]
Bug 1287010 - Extension.jsm optimization: Use pathObj

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73168/diff/1-2/

Comment 20

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783245 [details]
Bug 1287010 - Use minimal global scope for ext-*.js scripts

https://reviewboard.mozilla.org/r/73152/#review71200

::: toolkit/components/extensions/ExtensionGlobalScope.jsm:31
(Diff revision 2)
> +XPCOMUtils.defineLazyModuleGetter(this, "ExtensionUtils",
> +                                  "resource://gre/modules/ExtensionUtils.jsm");
> +XPCOMUtils.defineLazyModuleGetter(this, "require",
> +                                  "resource://devtools/shared/Loader.jsm");
> +
> +let _internalGlobals = new WeakMap();

Please don't use underscore prefixes. If it's not exported, it should be considered private (even though there's a way around that, as you've seen).

::: toolkit/components/extensions/ExtensionGlobalScope.jsm:55
(Diff revision 2)
> + */
> +this.loadExtScriptInScope = (scriptUrl, apiManager) => {
> +  // Different SchemaAPIManagers should have different globals.
> +  let global = _internalGlobals.get(apiManager);
> +  if (!global) {
> +    global = Object.create(this);

Can we make the proto be null here? Anything in ExtensionGlobalScope will still be accessible since it's the global.

Comment 21

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Hi Rob,
Can you post a single patch that includes all the changes? It's great that you've managed to split it up like this, but I'm having a hard time reviewing it this way. It would be much easier if I could see the final version of everything. I'm not sure if you can do this in ReviewBoard. If not, can you just post a normal Splinter patch?

I'm pretty close to understanding it all, but I still want to make one final pass over everything.

Thanks,
Bill

Comment 22

[Rob Wu [:robwu]]

Comment on attachment 8783245 [details]
Bug 1287010 - Use minimal global scope for ext-*.js scripts

https://reviewboard.mozilla.org/r/73152/#review71200

> Please don't use underscore prefixes. If it's not exported, it should be considered private (even though there's a way around that, as you've seen).

The scripts run in this global scope and can therefore make use of any variables declared here. With the guarantee that these scripts can use the globals, the Cu/Ci/Cc/XPComUtils boilerplate can be removed from the scripts (many scripts already assume that these exist).

I've added an underscore to make sure that it is really private, even though the global namespace is shared with the other ext-*.js scripts.

> Can we make the proto be null here? Anything in ExtensionGlobalScope will still be accessible since it's the global.

I'll try it (on try).

Comment 23

[Rob Wu [:robwu]]

(In reply to Bill McCloskey (:billm) from comment #21)
> Hi Rob,
> Can you post a single patch that includes all the changes? It's great that
> you've managed to split it up like this, but I'm having a hard time
> reviewing it this way. It would be much easier if I could see the final
> version of everything. I'm not sure if you can do this in ReviewBoard. If
> not, can you just post a normal Splinter patch?
> 
> I'm pretty close to understanding it all, but I still want to make one final
> pass over everything.

Click on the "Squashed Diff" link at the top of reviewboard.

Comment 24

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Use sandbox instead of JSM for global separation

Review commit: https://reviewboard.mozilla.org/r/73786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73786/

Comment 25

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Refactor shouldInject / pathObj

Split the `shouldInject` method into separate methods:
- `shouldInject` to determine whether the API (or namespace)
  should be injected.
- `getImplementation` to return the actual implementation.

Introduced `ISchemaAPIImplementation` for documentation purposes, and
two concrete implementations `LocalAPIImplementation` and
`ProxyAPIImplementation` which provide the functionality to run a local
and remote implementation of the API for which the schema API is
generated, respectively. These classes store the necessary details for
the invocation, so the methods that were formerly in the `Context` in
Schemas.jsm no longer get the `pathObj`, `path` or `name` parameters.

And merge the `path` and `name` in the implementation of remote APIs
because there is no need for having them separate, as the callers and
callees often did redundant pre/post-processing on `data.path` because
of the way it was implemented.

Review commit: https://reviewboard.mozilla.org/r/73788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73788/

Comment 26

[Rob Wu [:robwu]]

Comment on attachment 8783245 [details]
Bug 1287010 - Use minimal global scope for ext-*.js scripts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73152/diff/2-3/

Comment 27

[Rob Wu [:robwu]]

Comment on attachment 8783246 [details]
Bug 1287010 - Add pathObj parameter to Schemas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73154/diff/2-3/

Comment 28

[Rob Wu [:robwu]]

Comment on attachment 8783247 [details]
Bug 1287010 - Make environment of Context explicit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73156/diff/2-3/

Comment 29

[Rob Wu [:robwu]]

Comment on attachment 8783248 [details]
Bug 1287010 - Move Management logic to SchemaAPIManager

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73158/diff/2-3/

Comment 30

[Rob Wu [:robwu]]

Comment on attachment 8783249 [details]
Bug 1287010 - Prepare for moving content script APIs to schemas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73160/diff/2-3/

Comment 31

[Rob Wu [:robwu]]

Comment on attachment 8783250 [details]
Bug 1287010 - Use schema-generated i18n for all contexts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73162/diff/2-3/

Comment 32

[Rob Wu [:robwu]]

Comment on attachment 8783251 [details]
Bug 1287010, 1286712 - Use schema-generated runtime API, split ext-runtime.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73164/diff/2-3/

Comment 33

[Rob Wu [:robwu]]

Comment on attachment 8783252 [details]
Bug 1287010 - Use schema-generated extension, split ext-extension.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73166/diff/2-3/

Comment 34

[Rob Wu [:robwu]]

Comment on attachment 8783253 [details]
Bug 1287010 - Extension.jsm optimization: Use pathObj

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73168/diff/2-3/

Comment 35

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8784270 [details]
Bug 1287010 - Use sandbox instead of JSM for global separation

https://reviewboard.mozilla.org/r/73786/#review71796

::: toolkit/components/extensions/ExtensionUtils.jsm:1681
(Diff revision 1)
> +   * @param {string} scriptUrl The URL of the ext-*.js script.
> +   */
>    loadScript(scriptUrl) {
> -    loadExtScriptInScope(scriptUrl, this);
> +    // Create the object in the context of the sandbox so that the script runs
> +    // in the sandbox's context instead of here.
> +    let scope = this.global.Object.create(null);

I don't think this will create the object in the correct global. You should use Cu.createObjectIn.

Comment 36

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8784271 [details]
Bug 1287010 - Refactor shouldInject / pathObj

https://reviewboard.mozilla.org/r/73788/#review71808

::: toolkit/components/extensions/Extension.jsm:296
(Diff revision 1)
> -  for (let elt of path) {
>      // If we get a null object before reaching the requested path
>      // (e.g. the API object is returned only on particular kind of contexts instead
>      // of based on WebExtensions permissions, like it happens for the devtools APIs),
>      // stop searching and return undefined.
> +    // TODO(robwu): This should never be reached. If an API is not available for

Why is this a TODO?

::: toolkit/components/extensions/ExtensionUtils.jsm:1425
(Diff revision 1)
> + * An object that runs the implementation of a schema API. Instantiations of
> + * this interfaces are used by Schemas.jsm.
> + *
> + * @interface
> + */
> +class ISchemaAPIImplementation { // eslint-disable-line no-unused-vars

Please just call this SchemaAPIInterface.

::: toolkit/components/extensions/ExtensionUtils.jsm:1657
(Diff revision 1)
> +      return;
> +    }
> +    set.remove(listener);
> +
> +    if (set.size == 0) {
> +      this.childApiManager.messageManager.sendAsyncMessage("Extension:RemoveListener", {

This seems to be a pre-existing bug. Should be API:RemoveListener.

::: toolkit/components/extensions/Schemas.jsm:1269
(Diff revision 1)
>          if (this.hasAsyncCallback) {
>            callback = actuals.pop();
>          }
> -        return context.callAsyncFunction(pathObj, path, name, actuals, callback);
> +        if (callback === null && context.isChromeCompat) {
> +          // We pass an empty stub function as a default callback for
> +          // the `chrome` API, so promisr objects are not returned,

promise, not promisr

Comment 37

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783246 [details]
Bug 1287010 - Add pathObj parameter to Schemas

https://reviewboard.mozilla.org/r/73154/#review71218

Comment 38

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783247 [details]
Bug 1287010 - Make environment of Context explicit.

https://reviewboard.mozilla.org/r/73156/#review71214

::: toolkit/components/extensions/Extension.jsm:166
(Diff revision 2)
> -   *     Used to determine whether the API should be generated when the caller
> -   *     requests a subset of the available APIs (e.g. in content scripts).
> +   *     Intended to match the namespace of the generated API, but not used at
> +   *     the moment - see bugzil.la/1295774.
> +   * @param {string} envType Restricts the API to contexts that run in the
> +   *    given environment. Must be one of the following:
> +   *     - "addon_parent" - addon APIs that runs in the main process.
> +   *     - "addon_child" - addon APIs that may be run in an addon process.

Can we take out "may be"?

Comment 39

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783248 [details]
Bug 1287010 - Move Management logic to SchemaAPIManager

https://reviewboard.mozilla.org/r/73158/#review71224

Comment 40

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783249 [details]
Bug 1287010 - Prepare for moving content script APIs to schemas

https://reviewboard.mozilla.org/r/73160/#review71256

::: toolkit/components/extensions/ExtensionUtils.jsm:1434
(Diff revision 2)
> -  constructor(context, messageManager, namespaces, contextData) {
> +  constructor(context, messageManager, localApi, contextData) {
>      this.context = context;
>      this.messageManager = messageManager;
> -    this.namespaces = namespaces;
>  
> +    this.localApi = localApi;

Let's call this localApis. Also, please comment what this is for.

Comment 41

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783250 [details]
Bug 1287010 - Use schema-generated i18n for all contexts

https://reviewboard.mozilla.org/r/73162/#review71832

Comment 42

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783251 [details]
Bug 1287010, 1286712 - Use schema-generated runtime API, split ext-runtime.js

https://reviewboard.mozilla.org/r/73164/#review71834

Comment 43

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783252 [details]
Bug 1287010 - Use schema-generated extension, split ext-extension.js

https://reviewboard.mozilla.org/r/73166/#review71836

Comment 44

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8783253 [details]
Bug 1287010 - Extension.jsm optimization: Use pathObj

https://reviewboard.mozilla.org/r/73168/#review71838

Comment 45

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Also, as we discussed, I would like the SchemaAPIImplementation stuff to inherit from SchemaAPIInterface.

Comment 46

[Rob Wu [:robwu]]

Comment on attachment 8784271 [details]
Bug 1287010 - Refactor shouldInject / pathObj

https://reviewboard.mozilla.org/r/73788/#review71808

> Why is this a TODO?

Because this bail-out only works for local APIs, and not for remote APIs. 
Local APIs would be excluded through shouldInject, but with remote APIs the schema would generate the API which is proxied to a dead end.

I've expanded on the comment.

Comment 47

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - Add test for SchemaAPIManager's loadScript

And change `this.global.Object.create(null)` to
`Cu.createObjectIn(this.global)`. The tests pass either way, but
`Cu.createObjectIn` is more explicit.

Review commit: https://reviewboard.mozilla.org/r/73968/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73968/

Comment 48

[Rob Wu [:robwu]]

Attachment: Bug 1287010 - s/Extension:RemoveListener/API:RemoveListener/

This fix is not related to the referenced bug but came up during review.

Review commit: https://reviewboard.mozilla.org/r/73970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/73970/

Comment 49

[Rob Wu [:robwu]]

Comment on attachment 8783247 [details]
Bug 1287010 - Make environment of Context explicit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73156/diff/3-4/

Comment 50

[Rob Wu [:robwu]]

Comment on attachment 8783248 [details]
Bug 1287010 - Move Management logic to SchemaAPIManager

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73158/diff/3-4/

Comment 51

[Rob Wu [:robwu]]

Comment on attachment 8783249 [details]
Bug 1287010 - Prepare for moving content script APIs to schemas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73160/diff/3-4/

Comment 52

[Rob Wu [:robwu]]

Comment on attachment 8783250 [details]
Bug 1287010 - Use schema-generated i18n for all contexts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73162/diff/3-4/

Comment 53

[Rob Wu [:robwu]]

Comment on attachment 8783251 [details]
Bug 1287010, 1286712 - Use schema-generated runtime API, split ext-runtime.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73164/diff/3-4/

Comment 54

[Rob Wu [:robwu]]

Comment on attachment 8783252 [details]
Bug 1287010 - Use schema-generated extension, split ext-extension.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73166/diff/3-4/

Comment 55

[Rob Wu [:robwu]]

Comment on attachment 8783253 [details]
Bug 1287010 - Extension.jsm optimization: Use pathObj

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73168/diff/3-4/

Comment 56

[Rob Wu [:robwu]]

Comment on attachment 8784270 [details]
Bug 1287010 - Use sandbox instead of JSM for global separation

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73786/diff/1-2/

Comment 57

[Rob Wu [:robwu]]

Comment on attachment 8784271 [details]
Bug 1287010 - Refactor shouldInject / pathObj

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73788/diff/1-2/

Comment 58

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8784610 [details]
Bug 1287010 - Add test for SchemaAPIManager's loadScript

https://reviewboard.mozilla.org/r/73968/#review71862

Comment 59

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8784611 [details]
Bug 1287010 - s/Extension:RemoveListener/API:RemoveListener/

https://reviewboard.mozilla.org/r/73970/#review71864

Comment 60

[Rob Wu [:robwu]]

Comment on attachment 8783245 [details]
Bug 1287010 - Use minimal global scope for ext-*.js scripts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73152/diff/3-4/

Comment 61

[Rob Wu [:robwu]]

Comment on attachment 8783246 [details]
Bug 1287010 - Add pathObj parameter to Schemas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73154/diff/3-4/

Comment 62

[Rob Wu [:robwu]]

Comment on attachment 8783247 [details]
Bug 1287010 - Make environment of Context explicit.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73156/diff/4-5/

Comment 63

[Rob Wu [:robwu]]

Comment on attachment 8783248 [details]
Bug 1287010 - Move Management logic to SchemaAPIManager

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73158/diff/4-5/

Comment 64

[Rob Wu [:robwu]]

Comment on attachment 8783249 [details]
Bug 1287010 - Prepare for moving content script APIs to schemas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73160/diff/4-5/

Comment 65

[Rob Wu [:robwu]]

Comment on attachment 8783250 [details]
Bug 1287010 - Use schema-generated i18n for all contexts

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73162/diff/4-5/

Comment 66

[Rob Wu [:robwu]]

Comment on attachment 8783251 [details]
Bug 1287010, 1286712 - Use schema-generated runtime API, split ext-runtime.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73164/diff/4-5/

Comment 67

[Rob Wu [:robwu]]

Comment on attachment 8783252 [details]
Bug 1287010 - Use schema-generated extension, split ext-extension.js

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73166/diff/4-5/

Comment 68

[Rob Wu [:robwu]]

Comment on attachment 8783253 [details]
Bug 1287010 - Extension.jsm optimization: Use pathObj

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73168/diff/4-5/

Comment 69

[Rob Wu [:robwu]]

Comment on attachment 8784270 [details]
Bug 1287010 - Use sandbox instead of JSM for global separation

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73786/diff/2-3/

Comment 70

[Rob Wu [:robwu]]

Comment on attachment 8784271 [details]
Bug 1287010 - Refactor shouldInject / pathObj

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73788/diff/2-3/

Comment 71

[Rob Wu [:robwu]]

Comment on attachment 8784610 [details]
Bug 1287010 - Add test for SchemaAPIManager's loadScript

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73968/diff/1-2/

Comment 72

[Rob Wu [:robwu]]

Comment on attachment 8784611 [details]
Bug 1287010 - s/Extension:RemoveListener/API:RemoveListener/

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/73970/diff/1-2/

Comment 73

[Rob Wu [:robwu]]

The try server shows many red entries because some jobs have no WebExtensions test in their set, and "--tag webextensions" filters out those.

Comment 74

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07e6245571fb
Use minimal global scope for ext-*.js scripts r=billm
https://hg.mozilla.org/integration/autoland/rev/3b029657ddf9
Add pathObj parameter to Schemas r=billm
https://hg.mozilla.org/integration/autoland/rev/e5ee47173dbd
Make environment of Context explicit. r=billm
https://hg.mozilla.org/integration/autoland/rev/61638ddb612c
Move Management logic to SchemaAPIManager r=billm
https://hg.mozilla.org/integration/autoland/rev/aac2a4039d9a
Prepare for moving content script APIs to schemas r=billm
https://hg.mozilla.org/integration/autoland/rev/e4ce08beaf74
Use schema-generated i18n for all contexts r=billm
https://hg.mozilla.org/integration/autoland/rev/2427f8eb4e83
1286712 - Use schema-generated runtime API, split ext-runtime.js r=billm
https://hg.mozilla.org/integration/autoland/rev/598895fae31d
Use schema-generated extension, split ext-extension.js r=billm
https://hg.mozilla.org/integration/autoland/rev/becfa1ce1bad
Extension.jsm optimization: Use pathObj r=billm
https://hg.mozilla.org/integration/autoland/rev/e3fb102636dc
Use sandbox instead of JSM for global separation r=billm
https://hg.mozilla.org/integration/autoland/rev/c78a0b3e1152
Refactor shouldInject / pathObj r=billm
https://hg.mozilla.org/integration/autoland/rev/0ff65db84b3f
Add test for SchemaAPIManager's loadScript r=billm
https://hg.mozilla.org/integration/autoland/rev/cd4ed9909dc9
s/Extension:RemoveListener/API:RemoveListener/ r=billm

Comment 75

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07e6245571fb
https://hg.mozilla.org/mozilla-central/rev/3b029657ddf9
https://hg.mozilla.org/mozilla-central/rev/e5ee47173dbd
https://hg.mozilla.org/mozilla-central/rev/61638ddb612c
https://hg.mozilla.org/mozilla-central/rev/aac2a4039d9a
https://hg.mozilla.org/mozilla-central/rev/e4ce08beaf74
https://hg.mozilla.org/mozilla-central/rev/2427f8eb4e83
https://hg.mozilla.org/mozilla-central/rev/598895fae31d
https://hg.mozilla.org/mozilla-central/rev/becfa1ce1bad
https://hg.mozilla.org/mozilla-central/rev/e3fb102636dc
https://hg.mozilla.org/mozilla-central/rev/c78a0b3e1152
https://hg.mozilla.org/mozilla-central/rev/0ff65db84b3f
https://hg.mozilla.org/mozilla-central/rev/cd4ed9909dc9