Closed
Bug 1287082
Opened 10 years ago
Closed 10 years ago
Move GtkExpander to WidgetCache
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: stransky, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
5.08 KB,
patch
|
acomminos
:
review+
|
Details | Diff | Splinter Review |
|
5.19 KB,
patch
|
Details | Diff | Splinter Review |
Let's move other widgets to WidgetCache and use them in other widget code.
|
Reporter | |
Updated•10 years ago
|
Summary: Move GtkExpander_new to WidgetCache → Move GtkExpander to WidgetCache
|
|
Reporter | |
Comment 1•10 years ago
|
||
There's the patch, Thanks!
Attachment #8771380 -
Flags: review?(andrew)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8771380 [details] [diff] [review]
patch
Review of attachment 8771380 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
Attachment #8771380 -
Flags: review?(andrew) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
Thanks, there's a patch for check-in. Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e210a2f2f550
|
|
Reporter | |
Updated•10 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e44c9f57299f
Move GtkExpander widget from gtk3drawing.cpp to WidgetCache, r=acomminos
Keywords: checkin-needed
|
||
Comment 5•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•