1287142 - Make pointerevent_touch-action-inherit_parent-none_touch-manual.html pass with APZ

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

On a windows touch device, the pointerevent_touch-action-inherit_parent-none_touch-manual.html test fails. Note that in order to run this you have to do some fiddling with manifest files and such, it's not run in automation.

The first scroll on the page is correctly prevented, but the second one (after the subframe contents get layerized) is not. Looking at the layer tree, it seems that the no-action region ends up on the layer containing the scrollframe, rather than the layer containing the scrolled contents.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

This applies on top of the patch from bug 1286957 but is logically independent. The patch works by making sure the touch-action property from the scrollable element is applied to both the scrollframe and the scrolled frame, which I believe is consistent with the spec text:

"Then examine the touch-action property of each element between the hit tested element and the element with the default touch behavior (including both the hit tested element and the element with the default touch behavior)." [1]

The "element with the default touch behaviour" is the scrollable element, and so for elements inside the scrolled frame, the scrollable element should be included. For touches on the scrollable element's outer frame, the scrollable element should be included as the "hit tested element".

[1] https://www.w3.org/TR/pointerevents/#the-touch-action-css-property

Comment 3

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9229de2d992 includes this patch.

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8772142 [details] [diff] [review]
Patch

I haven't looked at the other callers of GetTouchActionFromFrame, but would they want this same behaviour (looking at the scroll frame for a scrolled frame)?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

The only other caller of GetTouchActionFromFrame is at [1] and that already does it as part of a walk in the frame tree, so it should already be encountering the scrollframe as part of that walk.

[1] http://searchfox.org/mozilla-central/rev/bfcc10319e4e3ce78367fa9bba9316f7eb5248b6/gfx/layers/apz/util/TouchActionHelper.cpp#88

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch v2

Now includes another hunk to avoid calling AddFrame on the same frame twice (see bug 1286957 comment 6).

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/439867de6935
Ensure that the touch-action property on the scrollable element is applied to both the inner and outer scrollframe. r=tnikkel

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/439867de6935