Closed Bug 1287163 Opened 3 years ago Closed 3 years ago

[FlyWeb] Remove over-strict asserts in InternalResponse IPC code

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: djvj, Assigned: djvj)

References

Details

Attachments

(1 file)

fix-internal-response-ipc-asserts.patch
1.36 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
Getting content-crashes in debug build when responding to requests with directly-instantiated Response objects, instead of using forwarding Responses.

This is due to extraneous asserts checking that mURLList is non-empty when trying to send an InternalResponse over content/parent IPC.
Attachment #8771487 - Flags: review?(jonas)
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd7eaf008b62
Remove over-strict asserts in InternalResponse IPC code. r=sicking
https://hg.mozilla.org/mozilla-central/rev/fd7eaf008b62
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.