1287235 - sdk/event/utils.js WeakValueGetterSetter should use try/cache around Cu.getWeakReference

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

In bug 1267693 I made input.value a weak reference in most cases.  This is done using Cu.getWeakReference when the event value is an object.

We should really put the getWeakReference() call in a try/catch, though.  If a native object that does not implement nsISupportsWeakReference is passed as the event then the current code will throw.

I don't know of any instance of this, but we should just do it proactively to be correct.

I'll fix this on Monday.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Wrap addon-sdk's Cu.getWeakReference() in a try/catch in case native objects are passed. r=bz

Boris, this is an issue we spoke about a few days ago.  I added a Cu.getWeakReference() to addon-sdk, but I can't guarantee the value I'm wrapping is safe to be a weak reference.  It can be a js value or a native object.  Per your suggestion I'm just wrapping it in a try/catch here.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8772427 [details] [diff] [review]
Wrap addon-sdk's Cu.getWeakReference() in a try/catch in case native objects are passed. r=bz

r=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/402ae3d3dec6
Wrap addon-sdk's Cu.getWeakReference() in a try/catch in case native objects are passed. r=bz

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/402ae3d3dec6

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8772427 [details] [diff] [review]
Wrap addon-sdk's Cu.getWeakReference() in a try/catch in case native objects are passed. r=bz

Approval Request Comment
[Feature/regressing bug #]: Minor fix to bug 1267693 which is being uplifted.
[User impact if declined]: Avoid some rare, but potential addon compat issues with bug 1267693.
[Describe test coverage new/current, TreeHerder]: Existing tests.
[Risks and why]: None.
[String/UUID change made/needed]: None

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8772427 [details] [diff] [review]
Wrap addon-sdk's Cu.getWeakReference() in a try/catch in case native objects are passed. r=bz

sure, let's take it in aurora. Thanks

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/3ecc86179a9a

Comment 8

[Ken Brown]

Attachment: alt-3.zip

Commons