1287302 - awesome bar tries to load single term as url but tld is invalid

Status: RESOLVED DUPLICATE of bug 1080682

(Firefox :: Address Bar, defect)

Description

[Dietrich Ayala (:dietrich)]

50.0a1 (2016-07-16)

STR:

1. enter "pm2.5" in the url bar, hit enter

Expected: Search engine results for "pm2.5"

Actual: Firefox tries to load "http://www.pm2.5" as a website

IIUC, we could theoretically have .5 as a TLD at some point in the future, but right now this is just a bug in the awesomebar code.

Screenshot: https://i.imgur.com/FdN6WBy.png

Is this a regression?

Comment 1

[Marco Bonardo [:mak]]

I'm not sure why in this case the docshell, after failing to dns resolve the domain, doesn't fallback to a search. Maybe Gijs knows if it's expected?
From the locationbar point of view, we do the right thing, we try to fixup it, we see that fixupuri thinks this is an URI, and we show a visit entry. From that point on we just pass control to the docshell.

Comment 2

[:Gijs (he/him)]

(In reply to Marco Bonardo [::mak] from comment #1)
> I'm not sure why in this case the docshell, after failing to dns resolve the
> domain, doesn't fallback to a search. Maybe Gijs knows if it's expected?

I think the fallback was deliberately limited to only TLD-less lookups when it was implemented aaaaaaaages ago.

bug 1080682 covers doing this for unknown TLDs, because we don't want "mozzilla.org" to go to search necessarily because of privacy considerations (ie we show a "server not found" error page for known TLDs). AIUI the holdup is that we can't trust the PSL if we don't improve how we keep it up-to-date, and nobody has found time to actually implement changing the storage format (AIUI it's hardcoded now) of the PSL, implement a kinto-based updater, etc. etc.