Closed
Bug 1287308
Opened 8 years ago
Closed 8 years ago
remove old NS_STYLE_HINT_NONE constant
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: chenpighead, Assigned: chenpighead)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
This is part of the work in Bug 1077851, eliminating usage of NS_STYLE_HINT_* in favor of nsChangeHint_*. Compared with other NS_STYLE_HINT_*, NS_STYLE_HINT_NONE is quite independent. So, I'm planning to fix it in this bug.
Assignee | ||
Comment 1•8 years ago
|
||
Replace all the usages of NS_STYLE_HINT_NONE with nsChangeHint(0). Review commit: https://reviewboard.mozilla.org/r/64766/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64766/
Attachment #8771730 -
Flags: review?(dbaron)
Attachment #8771731 -
Flags: review?(dbaron)
Assignee | ||
Comment 2•8 years ago
|
||
Remove NS_STYLE_HINT_NONE definition in nsChangeHint. Fix related debug log in RestyleManager. Review commit: https://reviewboard.mozilla.org/r/64768/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/64768/
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment on attachment 8771730 [details] Bug 1287308 - part1: replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0). https://reviewboard.mozilla.org/r/64766/#review61790 Your commit message is currently: >Bug 1287308 - part1: replace NS_STYLE_HINT_NONE with nsChangeHint(0). > >Replace all the usages of NS_STYLE_HINT_NONE with nsChangeHint(0). "usages" should be "uses". But you really don't need the bug's summary separately from which part of the bug. All you need for the commit message is: Bug 1287308 part 1 - replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0) r=dbaron with that or similar
Attachment #8771730 -
Flags: review?(dbaron) → review+
Comment on attachment 8771731 [details] Bug 1287308 - part2: remove old NS_STYLE_HINT_NONE constant. https://reviewboard.mozilla.org/r/64768/#review61792
Attachment #8771731 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8771730 [details] Bug 1287308 - part1: replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0). Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64766/diff/1-2/
Attachment #8771730 -
Attachment description: Bug 1287308 - part1: replace NS_STYLE_HINT_NONE with nsChangeHint(0). → Bug 1287308 - part1: replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0).
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8771731 [details] Bug 1287308 - part2: remove old NS_STYLE_HINT_NONE constant. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/64768/diff/1-2/
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to David Baron :dbaron: ⌚️UTC+8 (review requests must explain patch) from comment #3) > Comment on attachment 8771730 [details] > Bug 1287308 - part1: replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0). > > https://reviewboard.mozilla.org/r/64766/#review61790 > > Your commit message is currently: > >Bug 1287308 - part1: replace NS_STYLE_HINT_NONE with nsChangeHint(0). > > > >Replace all the usages of NS_STYLE_HINT_NONE with nsChangeHint(0). > > "usages" should be "uses". > > But you really don't need the bug's summary separately from which part of > the bug. All you need for the commit message is: > > Bug 1287308 part 1 - replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0) > > r=dbaron with that or similar Will do. Thank you for the review.
Pushed by jichen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/78bff0b2ded4 part1: replace uses of NS_STYLE_HINT_NONE with nsChangeHint(0). r=dbaron https://hg.mozilla.org/integration/autoland/rev/0d1e96f2ac72 part2: remove old NS_STYLE_HINT_NONE constant. r=dbaron
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/78bff0b2ded4 https://hg.mozilla.org/mozilla-central/rev/0d1e96f2ac72
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•