1287310 - Fix asymmetry for new pane toggle

Status: VERIFIED FIXED

(DevTools :: General, defect, P3)

Description

[magicp]

Attachment: pane-toggle.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160716030215

Steps to reproduce:

1. Start Nightly
2. Open DevTools > Inspector
3. Confirm the pane toggle


Actual results:

New pane toggle is not symmetry. Especially arrow.


Expected results:

Place arrow in the symmetry.

Comment 1

[magicp]

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a097b61f58102776941bd3fa0023092ac3f27a3f&tochange=006a4f4e68522332a36fd7eccd9664b73efae975

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Helen, any thoughts about this?

Comment 3

[Helen V. Holmes (:helenvholmes) (:✨)]

It's asymmetrical because of pixel-snapping, so this is a problem that if fixed would create a fuzziness bug. Because of that I'm WONTFIX'ing it.

Comment 4

[magicp]

Attachment: expected-pane-toggle.png

(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?)(unavail.18.7-21.7) from comment #3)
> It's asymmetrical because of pixel-snapping, so this is a problem that if
> fixed would create a fuzziness bug. Because of that I'm WONTFIX'ing it.

Hi Helen, could you check expected image? Thanks.

Comment 5

[magicp]

Attachment: pane-collapse.svg

Comment 6

[magicp]

Attachment: pane-expand.svg

Comment 7

[Tim Nguyen :ntim]

Attachment: Non pixel snapped corners

magicp, I'm noticing the arrow corner (circled in the screenshot) is not snapped to the pixel grid which will likely cause the icon to be blurry on 1x screens.

Comment 8

[magicp]

Attachment: is-this-brully.png

Hi Tim, you are correct. It should be snapped to the pixel grid. My point of view is symmetry. But is this blurry? If so, should remove rounded corners.

Comment 9

[magicp]

Attachment: is-this-blurry.png

Comment 10

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: symmetry.patch

Adds in the new svgs from magicp. Seems like they're pixelsnapped, but I can't tell without my display.

Tim, can you double check?

Doesn't solve the arrow issue.

Comment 11

[Tim Nguyen :ntim]

Comment on attachment 8774831 [details] [diff] [review]
symmetry.patch

Review of attachment 8774831 [details] [diff] [review]:
-----------------------------------------------------------------

There seems to be loads of unrelated changes in this.

Comment 12

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: symmetry.patch

Whoops, sorry about that!

Comment 13

[Tim Nguyen :ntim]

Comment on attachment 8775971 [details] [diff] [review]
symmetry.patch

Review of attachment 8775971 [details] [diff] [review]:
-----------------------------------------------------------------

Based on magicp's screenshot on an 1x screen, the new icons seem alright to me.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/1460b360645d
Fix asymmetry for new pane toggle. r=ntim

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1460b360645d

Comment 16

[Saddam Hossain]

I have reproduced this Bug on Nightly 50.0a1 (2016-07-16)  on Windows 10, 64 Bit!

The bug's fix is now verified on latest  Nightly 51.0a1 (2016-08-04)

Nightly 51.0a1:
Build ID 	20160804030441
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160803]

Comment 17

[Tim Nguyen :ntim]

Comment on attachment 8775971 [details] [diff] [review]
symmetry.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1260523 
[User impact if declined]: See attachment
[Describe test coverage new/current, TreeHerder]: on nightly, verified
[Risks and why]: low, SVG only change
[String/UUID change made/needed]: no

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8775971 [details] [diff] [review]
symmetry.patch

Image change and the fix has been verified, Aurora50+

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/81217ea8f4ff