Closed
Bug 1287321
Opened 4 years ago
Closed 4 years ago
Input range fires “input” event on mouseup
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla50
People
(Reporter: vsync.design, Assigned: smaug)
References
()
Details
Attachments
(4 files)
|
8.29 KB,
image/gif
|
Details | |
|
4.15 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
4.05 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.36 KB,
patch
|
Details | Diff | Splinter Review |
GIF.gif
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0 Build ID: 20160711002726 Steps to reproduce: Stackoverflow discussion: http://stackoverflow.com/q/38420339/104380 Demo page : http://jsbin.com/galijekovi/edit?html,css,js,output Firefox Version: 48.0b7 OS: windows 7 Try to click the slider (input range) and then release the mouse Actual results: "events fired" count was incremented by "1" Expected results: "events fire" should not fire when releasing the mouse, only while dragging (input event) This causes bugs in sensitive cases where this is not the expected behavior.
|
Reporter | |
Updated•4 years ago
|
OS: Unspecified → Windows 7
Hardware: Unspecified → x86_64
|
||
Comment 2•4 years ago
|
||
Problem exist also on 48 on Linux.
Status: UNCONFIRMED → NEW
status-firefox47:
--- → affected
status-firefox48:
--- → affected
Component: Untriaged → DOM: Events
Ever confirmed: true
OS: Windows 7 → All
Product: Firefox → Core
Hardware: x86_64 → All
Version: 48 Branch → 47 Branch
|
||
Comment 3•4 years ago
|
||
Olli, I feel like I've seen you comment on a range bug recently ...
Flags: needinfo?(bugs)
|
Assignee | |
Comment 4•4 years ago
|
||
This is a simple bug fix.
Assignee: nobody → bugs
Flags: needinfo?(bugs)
|
|
Assignee | |
Comment 5•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a0c515dbe2be13d472290e779d8670ac3ea9ce6
|
|
Assignee | |
Updated•4 years ago
|
Attachment #8772618 -
Flags: review?(amarchesini)
|
||
Comment 6•4 years ago
|
||
Comment on attachment 8772618 [details] [diff] [review] range_mousemove.diff Review of attachment 8772618 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/html/test/test_bug1287321.html @@ +52,5 @@ > +</head> > +<body> > +<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1287321">Mozilla Bug 1287321</a> > +<p id="display"></p> > +<div id="content" style="display: none"> remove this <p> and <div> and <pre>
Attachment #8772618 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 7•4 years ago
|
||
I always keep them since that is what the mochitest generator gives. I always thought mochitest uses them for something, like for reporting results. But maybe not.
|
|
Assignee | |
Comment 8•4 years ago
|
||
|
|
Assignee | |
Comment 9•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed
|
||
Comment 10•4 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/fx-team/rev/8f018f9e7725 Don't fire input event on type=range when value hasn't changed. r=baku
Keywords: checkin-needed
|
||
Comment 11•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8f018f9e7725
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
|
||
Comment 12•2 years ago
|
||
i tried this scenario in 52 version, still i could see the issue
procedure to reproduce:
-----------------------
<input type="range" id="slice-range" value = 5 max = 100 >
<script>
$(document).ready(function(){
slider = document.getElementById("slice-range");
$("#slice-range").mousedown(function() {
console.log("when onmousedown" );
})
$("#slice-range").mouseup(function() {
console.log("when onmouseup" );
slider.value = 25
console.log("when onmouseup" ,slider.value );
})
$("#slice-range").keydown(function() {
console.log("when keydown" );
})
$("#slice-range").keyup(function() {
console.log("when keyup" );
slider.value = 25
console.log("when keyup" ,slider.value );
})
$("#slice-range").on("input", updateTarget.bind());
});
function updateTarget(){
console.log("printing inputs" , slider.value);
}
</script>
updatetarget() has been called during the mouseup event is triggered, but updatetarget() is not called during keyup event|
|
||
Comment 13•2 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #11) > https://hg.mozilla.org/mozilla-central/rev/8f018f9e7725 still i see issue, i can reproduce with the following code snipet: <input type="range" id="slice-range" value = 5 max = 100 > <script> $(document).ready(function(){ slider = document.getElementById("slice-range"); $("#slice-range").mousedown(function() { console.log("when onmousedown" ); }) $("#slice-range").mouseup(function() { console.log("when onmouseup" ); slider.value = 25 console.log("when onmouseup" ,slider.value ); }) $("#slice-range").keydown(function() { console.log("when keydown" ); }) $("#slice-range").keyup(function() { console.log("when keyup" ); slider.value = 25 console.log("when keyup" ,slider.value ); }) $("#slice-range").on("input", updateTarget.bind()); }); function updateTarget(){ console.log("printing inputs" , slider.value); } </script> in firefox expected to work as keypress event, but mouseup behaves differently. the same scenario i have tested in the chrome but works great
You need to log in
before you can comment on or make changes to this bug.
Description
•