1287345 - Consider running service worker threads at normal priority

Status: RESOLVED DUPLICATE of bug 1563950

(Core :: DOM: Service Workers, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently all non-chrome worker threads are run at low priority:

https://dxr.mozilla.org/mozilla-central/source/dom/workers/RuntimeService.cpp#1620

  int32_t priority = aWorkerPrivate->IsChromeWorker() ?
                     nsISupportsPriority::PRIORITY_NORMAL :
                     nsISupportsPriority::PRIORITY_LOW;

  if (NS_FAILED(thread->SetPriority(priority))) {
    NS_WARNING("Could not set the thread's priority!");
  }

We should consider running service workers at normal priority since they can be in the hot path for page load.

Comment 1

[Calvin Freitas]

It looks like this was addressed as part of a commit for another bug:

• https://hg.mozilla.org/mozilla-central/rev/38729643d8c439f5edc713a020197bb70f8b9fe7
• https://bugzilla.mozilla.org/show_bug.cgi?id=1563950

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

This was fixed by bug 1563950 which changed the exact hunk from comment 0 to always try and set normal priority; patch was https://phabricator.services.mozilla.com/D37694